Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the load balancer out of loadbalancer group and into a network group #39

Open
ADustyOldMuffin opened this issue Feb 25, 2022 · 4 comments
Labels
good first issue Good for newcomers hacktoberfest help wanted Extra attention is needed networking Issue relates to Networking products
Milestone

Comments

@ADustyOldMuffin
Copy link
Contributor

Somewhat breaking change we need to document well.

Here inside of the loadbalancer API definition

// Package v1alpha1 contains managed resources for DigitalOcean LoadBalancer
// services.
// +kubebuilder:object:generate=true
// +groupName=loadbalancer.do.crossplane.io
// +versionName=v1alpha1
package v1alpha1

We should update the groupName to be network instead as well as rename the folder the file is in. This is because we're going to group the resources by their type and load balancer would fall into the inside the purview of networking stuff.

@ADustyOldMuffin ADustyOldMuffin added good first issue Good for newcomers help wanted Extra attention is needed networking Issue relates to Networking products labels Feb 25, 2022
@ADustyOldMuffin ADustyOldMuffin added this to the v0.2.0 milestone Feb 25, 2022
@amoghrajesh
Copy link

@ADustyOldMuffin I would like to work on this for Hacktoberfest. Could you provide a clear list of what is needed and assign the issue to me?

@ADustyOldMuffin
Copy link
Contributor Author

Sure thing! The main thing is what was mentioned above, the groupName=loadbalancer.do.crossplane.io doesn't match other packages such as this one here.

The loadbalancer is apart of the Networking group of products and as such should be in that grouping, so that'd involve updating import references, the doc.go for it, and moving it's folder location. If you need any other information please let me know.

@amoghrajesh
Copy link

@ADustyOldMuffin I understand that the references do not match but what does grouping under a networking group mean? Can you share one reference where it grouped as?

@ADustyOldMuffin
Copy link
Contributor Author

ADustyOldMuffin commented Oct 4, 2022

apiVersion: loadbalancer.do.crossplane.io/v1alpha1

It affects this field in the CRD.

@amoghrajesh amoghrajesh removed their assignment May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers hacktoberfest help wanted Extra attention is needed networking Issue relates to Networking products
Projects
None yet
Development

No branches or pull requests

2 participants