-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Add missing ACM resources #617
WIP: Add missing ACM resources #617
Conversation
Signed-off-by: Anton Kaymakchi <[email protected]>
…e and add example Signed-off-by: Anton Kaymakchi <[email protected]>
b53cd7b
to
e9eeab6
Compare
/test-examples="examples/accesscontextmanager/v1beta1/serviceperimeterdryrunresource.yaml" |
/test-examples="examples/accesscontextmanager/v1beta1/serviceperimeterdryrunresource.yaml" |
… policy resource and add examples Signed-off-by: Anton Kaymakchi <[email protected]>
Signed-off-by: Anton Kaymakchi <[email protected]>
I noticed existing ACM resources do not necessary contain all fields that might be references and do not strictly follow rule about the fields that are represented as separate resources from contribution guide. Although changing them at the moment will likely be a breaking change. Also some of the resources (in particular all ingress/egress policies) are supposed to be recreated on any changes, preferably with Another concern is that all of resources cannot be tested automatically as require org-wide permissions. Please advise on the approaches here. |
Signed-off-by: Anton Kaymakchi <[email protected]>
Hi @StupidScience, Thank you for your effort. We would prefer you to handle the terraform provider upgrade in a different PR. An example PR: #593 And about adding a new resource and testing, you can follow: https://github.com/crossplane/upjet/blob/main/docs/adding-new-resource.md |
I'm closing this for now, please feel free to open separate PRs as I mentioned above. |
Description of your changes
This PR adds support for multiple missing ACM resources.
PR also contains terraform version bump to 5.41.0 as earliest where some of new resources were added. Let me know if you'd rather have it as separate PR.
Fixes #616
I have:
make reviewable
to ensure this PR is ready for review.backport release-x.y
labels to auto-backport this PR if necessary.How has this code been tested