fix(hack/prepare.sh): don't change a URL comment in the Makefile #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
tampakrap
force-pushed
the
fix/prepare_comment_templates_url
branch
from
bba0c8d to
55a3cd1
Compare
A previous sed command breaks a URL that is in a comment in the Makefile. This commit reverts that change Signed-off-by: Theo Chatzimichos <[email protected]>
Signed-off-by: Theo Chatzimichos <[email protected]>
tampakrap
force-pushed
the
fix/prepare_comment_templates_url
branch
from
55a3cd1 to
761ec6d
Compare
jeanduplessis
requested changes
Apr 4, 2024
Signed-off-by: Theo Chatzimichos <[email protected]>
tampakrap
force-pushed
the
fix/prepare_comment_templates_url
branch
from
fbc0603 to
c94e3b0
Compare
jeanduplessis
approved these changes
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A previous sed command breaks a URL that is in a comment in the Makefile.
This commit reverts that change
Description of your changes
Fixes #
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested