Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: bump up dependencies and enable metrics #69

Merged
merged 7 commits into from
Aug 2, 2024
Merged

chore: bump up dependencies and enable metrics #69

merged 7 commits into from
Aug 2, 2024

Conversation

cychiang
Copy link
Contributor

@cychiang cychiang commented Jul 23, 2024 •
edited
Loading

Description of your changes

Fixes #36, update dependencies as following:

  • go lint to 1.54.0
  • go version to 1.21.0
  • crossplane-runtime to 1.16.0
  • upjet to 1.4.0
  • controller-runtime to 0.17.0
  • controller-tools to 0.14.0
  • enable metrics

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

@cychiang cychiang changed the title chore: bump up some dependencies, and inline with latest upjet and crossplane-runtime chore: bump up dependencies and enable metrics Jul 30, 2024
cychiang added 4 commits July 30, 2024 14:45
@cychiang
Bump up upjet, crossplane-runtime and go version.
b377c0a 
Signed-off-by: Chuan-Yen Chiang <[email protected]>
@cychiang
Default go version set to 1.21
e4a90f7 
Bump up hashicorp/null version to 3.2.2

Signed-off-by: Chuan-Yen Chiang <[email protected]>
@cychiang
bump up workflow go version to 1.21
07ab7db 
Signed-off-by: Chuan-Yen Chiang <[email protected]>
@cychiang
add metrics
0e4a464 
Signed-off-by: Chuan-Yen Chiang <[email protected]>
@cychiang cychiang force-pushed the chore-bump-up-version-and-dependies branch from 9ef3ed3 to 0e4a464 Compare July 30, 2024 12:46
sergenyalcin
sergenyalcin reviewed Jul 30, 2024
View reviewed changes
Copy link
Member

@sergenyalcin sergenyalcin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @cychiang for this PR. Left two comments and asked guidance from @mergenci for another review.

internal/controller/zz_setup.go Outdated Show resolved Hide resolved
cmd/provider/main.go Outdated Show resolved Hide resolved
@sergenyalcin
Copy link
Member

Everything seems fine apart from the CI/local-deploy job. I could not reproduce the problem. I think after making green the CI job, this PR will be ready to merge. However, until now, I am not able to identify the problem.

@sergenyalcin
Copy link
Member

I am not sure it will resolve the problem but we may consider bumping the UP_VERSION to the at least v0.28.0 that is the version the providers use.

@cychiang
bump up up version to 0.28.0
fb74f96 
Signed-off-by: Chuan-Yen Chiang <[email protected]>
@cychiang
Copy link
Contributor Author

cychiang commented Aug 2, 2024

I am not sure it will resolve the problem but we may consider bumping the UP_VERSION to the at least v0.28.0 that is the version the providers use.

Done

@jeanduplessis jeanduplessis merged commit 13d8eb7 into crossplane:main Aug 2, 2024
8 checks passed
@jeanduplessis
Copy link
Collaborator

Thank you for all your effort on this PR @cychiang

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sergenyalcin sergenyalcin sergenyalcin left review comments

@mergenci mergenci mergenci left review comments

@jeanduplessis jeanduplessis jeanduplessis approved these changes

@ulucinar ulucinar Awaiting requested review from ulucinar ulucinar is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Keep upjet and other dependencies up-to-date
4 participants
@cychiang @sergenyalcin @jeanduplessis @mergenci