You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It seems to me that this code should go in the init method of the plugin. The whole point of plugins is that the core project should be agnostic about their behavior. If the current plugin loading mechanism isn't flexible enough to support the functionality then it needs to be updated, but we shouldn't put plugin specific logic in the core.
I think the sass config should be a key in the config.edn, the plugin should read the config and look for that key to find its configuration.
Sass code is the current code in cryogen-core. Refactoring it to a plugin would be interesting.
The last line of code was the code I want to add to cryogen-core.
It takes a sequence of function name from config.edn and execute them in sequence. It just a way to allow user to hook something to the default compile-assets pipeline.
However, I agree, It is lack of safeguard and have so many rooms for user or plugin developer to make mistakes.
The reference code repo
https://github.com/zerg000000/cryogen-less.git
It required one lines of changes in the core project( the
dorun
line).The text was updated successfully, but these errors were encountered: