Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task] Discovery plugin updates should require all branches terminate in leaf nodes #1276

Open
andrewazores opened this issue Dec 5, 2022 · 0 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@andrewazores
Copy link
Member

https://github.com/cryostatio/cryostat/blob/d6a438e721a3847bf55bcb3ee25bc117c0804a1b/src/main/java/io/cryostat/net/web/http/api/v2/DiscoveryPostHandler.java#L129

Plugin realm subtrees should always be published as a list of leaf (target) nodes, or as a list of environment nodes whose children are either more environment nodes or target nodes. All paths from the realm (the subtree root) downward should terminate in target nodes. Any branch that terminates (node with no children) in an environment node is a leafless branch and must be disallowed.

@andrewazores andrewazores added the bug Something isn't working label Dec 5, 2022
@andrewazores andrewazores added the good first issue Good for newcomers label Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
No open projects
Status: Pushed to 2.4.0
Status: Stretch Goals
Development

No branches or pull requests

1 participant