Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proper computation of the user choice parameter for generateSpendRequestResponse #103

Open
pschuermann97 opened this issue May 8, 2022 · 2 comments
Open

Proper computation of the user choice parameter for generateSpendRequestResponse #103

pschuermann97 opened this issue May 8, 2022 · 2 comments
Labels
question Further information is requested

Comments

@pschuermann97
Copy link
Collaborator

pschuermann97 commented May 8, 2022 •
edited
Loading

Emerged from issue #75.

We still use the transaction ID since it is allows for the code to compile and does not break anything (since the user choice is just displayed on UIs and not used for any further computations).

I would propose to use the basketID + reward item in basket as parameter value for generateSpendRequestResponse when calling it from the promotion service.
@pschuermann97 pschuermann97 mentioned this issue May 8, 2022
Closed
@this-kramer
Copy link
Member

Can you please add to the description of the issue? I do not understand what's wrong

@this-kramer this-kramer added the question Further information is requested label Jul 19, 2022
@pschuermann97
Copy link
Collaborator Author

see this comment from #75: #75 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@this-kramer @pschuermann97