Numeric Traits | Broken Filtering

[skiinginjeans]

Cool project thanks for sharing with us.

Using numeric trait values causes the build-rarities script to miss actual tokens at this line:
https://github.com/cryptoDevAmigos/rarity-analyzer/blob/main/packages/common-node/src/build-rarities.ts#L133

It ends up showing as [Missing] in the filtering functionality on the left nav which is undesirable given that the value is not actually missing;

I solved this on my fork by coercing the value to a string for equality matching:

.filter(t=>t.attributeRarities.some(a=>a.trait_type === x.trait_type && String(a.value) === String(x.value)))

There may be a better solution but this worked for me.

[skiinginjeans]

Worth noting that due to the rarity calculator 0 is still not a valid trait value:

This line filters out 0

const allAttributesRaw = metadata.flatMap(x => x.attributes).filter(x => !!x.value);

Nice chart here

 value     │  !value  │  !!value
━━━━━━━━━━━┿━━━━━━━━━━┿━━━━━━━━━━━
 false     │ ✔ true   │   false
 true      │   false  │ ✔ true
 null      │ ✔ true   │   false
 undefined │ ✔ true   │   false
 0         │ ✔ true   │   false
 -0        │ ✔ true   │   false
 1         │   false  │ ✔ true
 -5        │   false  │ ✔ true
 NaN       │ ✔ true   │   false
 ''        │ ✔ true   │   false
 'hello'   │   false  │ ✔ true