Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds validation to ensure CrystallEdge maps only contain fork-specific entities and no vanilla entities. The change enforces that all entities on maps prefixed with "CE" must have the "ForkFiltered" category.
Changes:
- Added a new test method
CECheckOnlyForkFilteredto validate entity categories on CrystallEdge maps - Integrated this validation into the existing
NoSavedPostMapInitTestworkflow
TheShuEd
commented
Feb 2, 2026
| continue; | ||
|
|
||
| Assert.That(proto.Categories.Contains(filterCategory), | ||
| $"\nMap {map} contains entities without FORK FILTERED category ({proto.Name})"); |
Contributor
Author
There was a problem hiding this comment.
replace from Name to ProtoId
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About the PR
A small injection has been added to PostMapInitTest, which validates that no vanilla entities are mapped on CrystallEdge maps.
fix #72