Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Console prompts hang test framework invocation #564

Open
Xenomega opened this issue Jul 11, 2024 · 1 comment
Open

Console prompts hang test framework invocation #564

Xenomega opened this issue Jul 11, 2024 · 1 comment

Comments

@Xenomega
Copy link
Member

Xenomega commented Jul 11, 2024

When installing crytic-compile on a new machine with hardhat, then attempting to compile a codebase, crytic-compile executes a command, and captures its output to reflect after the command finishes executing. The problem with this is, on first use of hardhat, you will get a stdin prompt asking you to confirm some settings:

xenomega@ubuntu:~/github/audit-treehouse-contracts$ npx hardhat compile

✔ Help us improve Hardhat with anonymous crash reports & basic usage data? (Y/n) · 

This will result in crytic-compile waiting for the command to end, but it will not end until the prompt is answered, but stdin/stdout is not forwarded during execution, meaning the user can't see or know there is a prompt to accept.

It's not a big deal in essence, you can run npx hardhat compile and see the prompt, answer it, and all future runs will work. But it might be worth forwarding stdin/stdout during execution so users don't hit this issue with any tools that have a prompt in the future.

@jkoppel
Copy link

jkoppel commented Jul 17, 2024

Looks like I hit this too, and got thrown hard. https://empirehacking.slack.com/archives/C7KKY517H/p1721030884810249

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants