Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider making --always-install the default #197

Open
devtooligan opened this issue Sep 8, 2023 · 4 comments
Open

Consider making --always-install the default #197

devtooligan opened this issue Sep 8, 2023 · 4 comments
Labels
good first issue Good for newcomers

Comments

@devtooligan
Copy link

I was poking around the code and discovered this great --always-install. It doesn't show up on the top level of help (and I previously didn't realize it shows up with no description if you do solc-select use --help.

But personally I think solc-select should --always-install by default and we change this option to --never-install

Either way, I think it would be nice to have this option listed on the top help screen.

@devtooligan
Copy link
Author

This issue got me again today.

I was thinking if there was a concern about automatically installing it we could accept user input like "Version 0.8.19 is not installed. Install y/N?"

@0xalpharush
Copy link
Contributor

I agree. We could add an --offline flag if users want to opt out of downloading

@legit-programmer
Copy link

Hi, I up am for solving this issue, please explain what is to be done in brief, as the details given above are not comprehensive...

@devtooligan
Copy link
Author

It would involve making the --always-install the default. removing that particular clarg. and then adding a new clarg called "--offline" which would make it not install by default.

@0xalpharush 0xalpharush added the good first issue Good for newcomers label Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants