Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lab worldcup can fail checks with low N #58

Open
KatherineCox opened this issue Mar 18, 2023 · 0 comments
Open

Lab worldcup can fail checks with low N #58

KatherineCox opened this issue Mar 18, 2023 · 0 comments
Assignees

Comments

@KatherineCox
Copy link

KatherineCox commented Mar 18, 2023

For worldcup, you can fail checks if your number of simulations N is low.

I had N at 10 when I ran check50 and it gave me this error:

:( correctly reports team information for Women's World Cup
    did not find team England

Since I was only adding teams to the count dictionary if they won, I guess with the low N value there was enough variability that expected teams didn't show up. Since N is hardcoded in the python script, it might be helpful to have a hint/reminder to set it back up to something higher when submitting.

Edit: Checks can also fail when N is high due to timeout.

@KatherineCox KatherineCox changed the title Lab world cup can fail checks with low N Lab worldcup can fail checks with low N Mar 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants