Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support timeout? #67

Open
kzidane opened this issue Apr 30, 2018 · 2 comments
Open

support timeout? #67

kzidane opened this issue Apr 30, 2018 · 2 comments
Assignees

Comments

@kzidane
Copy link
Member

kzidane commented Apr 30, 2018

style50 takes too long while checking certain files (e.g., Cloud9's backup files and files with huge amount of data such as that of a student who made an array out of US.txt contents and pasted it in one of the source files).

While some of these files we should certainly ignore by default and others have contents that don't make sense, should we also support something like --timeout x that will basically have style50 spend at most x seconds on checking a source file, reporting that the file is too big if the check didn't conclude within this time window? Not sure what that would mean for the overall score though. Any thoughts?

@cmlsharp
Copy link
Contributor

This strikes me as being outside the perview of style50. This is easily accomplished by running timeout x style50 ...

@kzidane
Copy link
Member Author

kzidane commented Apr 30, 2018

Right, but that would kill the whole style50 process, not just skip a file. Would we want that instead?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants