Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] Housekeeping #111

Open
6 of 16 tasks
nikgil opened this issue May 30, 2021 · 0 comments
Open
6 of 16 tasks

[feature] Housekeeping #111

nikgil opened this issue May 30, 2021 · 0 comments
Labels
feature New feature good first issue Good for newcomers

Comments

@nikgil
Copy link
Member

nikgil commented May 30, 2021

Is your feature request related to a problem? Please describe

Come to a point where I think bugs are more or less squashed in existing minibots so would be nice to comb over existing solution and take care of a few loose ends before continuing.

Describe the solution you'd like

  • Add pm2 flush megabot-dev to dev startup script. Hard to follow if errors are new or old sometimes.
  • Add pm2 flush megabot-prod to prod startup script. Same as above.
  • Change any isMod or isContributor explicit checks to use checkRuleList
  • Try to get the one skipped test in modchat to be working
  • Add stale PR closer to project and set for 4mths
  • Set prod bot to not listen to dev channel
  • Update specs (since actual implementations deviated a bit over time)
  • Create a contributing guidelines doc, outlining how code should be like in PRs
  • Change all messages with ++ prefix (non-test files) to use a dynamic prefix
  • Add ability for nodemon to auto restart bot when testing and modifications occur (just add -L to yarn start)
  • Clean testing (separate from modchat issue). This involves moving all instantiations to beforeEach or beforeAll and making sure all tests can be read in a given-when-then fashion, or comments supplied as to why this is not the case
  • Add icon for following dependencies on david-dm.org
  • Change client in rawMessageProxy.test.js to be Discord.Client, not the ad-hoc object.
  • Make sure there are no redundant checks anywhere (for example in pinByReaction we do a checkRuleList twice - once in pinByReaction and once in index, this should only happen once)
  • Make consistent folder structure - all subcommands should be under src/bots/<bot_name>/subCommands, and all reactions and other events should be under src/bots/<bot_name>/events
  • Make consistent naming for events - all file names in events should be onActionGoesHere.js for example onPinReaction.js when doing a pin.

Describe alternatives you've considered

N/A

Additional context

Can be done in a few PRs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant