Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] Fix Windows linting errors #163

Merged

Conversation

RogueArt
Copy link
Collaborator

Purpose of pull request

Related Issue: resolves #162

Note: This depends on another PR #161, so please only review the latest commit/diff for this one.

Attempting to run linting via yarn format and yarn lint runs into two issues on Windows:

  1. ESLint says that it can't find any .js files
  2. The pre-commit hook doesn't run as Powershell and Cmd don't support the && operator

Changes:

  • Change ESLint command to use escaped double quotes rather than single quotes to fix this issue on Windows
  • Separate the single command onto two lines so it succeeds on Windows and Mac/Linux
    • Note: The behavior is slightly different since before yarn format failing won't run yarn lint, but this is a quick and dirty fix that makes it compatible across both OS's

Pull request checklist

  • Branch and PR are named correctly
  • Updated relevant documentation
  • Tested with a tester bot
  • Wrote unit tests for changes

Testing instructions

Can run on both Windows and Mac/Linux

  1. Attempt to lint with yarn lint
  2. Attempt to commit changes and ensure pre-commit hook goes through properly

@RogueArt RogueArt changed the title [bug] Fix windows linting errors [bug] Fix Windows linting errors Apr 21, 2022
@RogueArt RogueArt force-pushed the bug/fix-windows-linting-errors branch from 582f515 to e4d6a59 Compare April 23, 2022 23:47
@nikgil nikgil changed the base branch from master to development April 24, 2022 15:28
@nikgil nikgil merged commit a497d5d into cscareerhub:development Apr 24, 2022
@RogueArt RogueArt mentioned this pull request Apr 25, 2022
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] Linting runs into errors on Windows
2 participants