[feature] FAQ bot add, list, and define #71
Conversation
|
Do you want to partition out the commands a bit to different PRs? Would be easier to review that way and incrementally upload to main bot without having to do massive rollbacks (if god forbid we had to) |
jackwherry
changed the title
jackwherry
changed the title
| let details = dedent(`**${faq.term}**: ${faq.definition}`); | ||
|
|
||
| if (addReferences) { | ||
| details += dedent(` |
There was a problem hiding this comment.
maybe prettier do do \n instead of this
|
|
||
| if (addId) { | ||
| details += dedent(` | ||
| ID: ${faq._id}`); |
| import addFaq from './subCommands/addFaq'; | ||
| import client from '../../client'; | ||
| import { commandHandler } from '../../utils'; | ||
| // import deleteFaq from './subCommands/deleteFaq'; |
There was a problem hiding this comment.
please don't leave comments in the code.
| import { commandHandler } from '../../utils'; | ||
| // import deleteFaq from './subCommands/deleteFaq'; | ||
| import defineFaq from './subCommands/defineFaq'; | ||
| // import editFaq from './subCommands/editFaq'; |
|
|
||
| let newFaq = await Faq({ | ||
| definition: args.slice(1).join(' '), | ||
| term: args[0] |
There was a problem hiding this comment.
@brendacs think that we would need to create multi word terms? Some FAQs in my mind may definitely be more than one word (examples: functional programming, data structures)
There was a problem hiding this comment.
i agree, that was my thought from the beginning
There was a problem hiding this comment.
@nikgil what about simply using hyphens instead of spaces? Spaces are generally understood as carrying semantic within commands, so I think it's safer (for extensibility) to keep it to a "single-word".
E.g. function-programming and data-structures
| let allFaqs = '**All FAQs:**\n\n'; | ||
|
|
||
| faqs.forEach( | ||
| (faq) => (allFaqs += `${getFormattedFaq(faq, true, showIds)}\n\n`) |
There was a problem hiding this comment.
later problem is getting this paginated
|
This issue is stale because it has been open at least 120 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
|
Any reason why Also, as a personal note, I think it'd be interesting to have aliases. For example:
|
|
Not scrapped per se as much as can be done in multiple PRs since they are pretty independent of each other |
Purpose of pull request
Related Issue: resolves #30
Pull request checklist
3/3 done
PR-specific checklist
++faq add++faq list++faq defineResponds to++faq delete++faq list -iHandles duplicates with++faq defineTesting instructions
++faq