Skip to content

Commit 7211615

Browse files
authored
Merge pull request #443 from cse-sim/fix-exterior-convection-heat-transfer-coefficient-cleanup
Fix exterior convection heat transfer coefficient for specified temperature boundary condition
2 parents f0de00b + b568d56 commit 7211615

File tree

13 files changed

+270
-268
lines changed

13 files changed

+270
-268
lines changed

src/cncult3.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2704,9 +2704,8 @@ void SBC::sb_SetCoeffs( // set convective and radiant coefficients
27042704
else if (sb_pXS->sfExCnd==C_EXCNDCH_SPECT)
27052705
{ sb_txa = sb_pXS->sfExT;
27062706
sb_txr = sb_txa;
2707-
sb_hcNat = sb_pXS->uX;
2708-
sb_hcFrc = 0.f;
2709-
sb_hxa = sb_hcMult * sb_hcNat;
2707+
sb_HCAmbient();
2708+
sb_hxa = sb_hcMult * (sb_hcNat + sb_hcFrc);
27102709
sb_hxr = 0.f;
27112710
}
27122711
else if (sb_pXS->sfExCnd == C_EXCNDCH_GROUND)
@@ -2939,6 +2938,7 @@ x printf( "Hit\n");
29392938

29402939
case C_CONVMODELCH_INPUT:
29412940
sb_hcNat = 1.f;
2941+
sb_hcFrc = 0.f;
29422942
break;
29432943

29442944
default:

test/1ZAttic.cse

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -201,8 +201,8 @@ ZONE Z1
201201
sfExT=50 //10 C ground temperature
202202
sfInAbs=INABSORP
203203
sfInHcModel = Unified //floor inside film coefficient
204-
sfExH=100000 //floor outside film coefficient
205-
sfExHcModel = Unified
204+
sfExHcMult=100000 //floor outside film coefficient
205+
sfExHcModel = INPUT
206206

207207
SURFACE North_Wall
208208
sfType=Wall

test/2ZAttic.cse

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -201,8 +201,8 @@ ZONE Z1
201201
sfExT=50 //10 C ground temperature
202202
sfInAbs=INABSORP
203203
sfInHcModel = Unified //floor inside film coefficient
204-
sfExH=100000 //floor outside film coefficient
205-
sfExHcModel = Unified
204+
sfExHcMult=100000 //floor outside film coefficient
205+
sfExHcModel = INPUT
206206

207207
SURFACE North_Wall
208208
sfType=Wall
@@ -390,8 +390,8 @@ ZONE Z2
390390
sfExT=50 //10 C ground temperature
391391
sfInAbs=INABSORP
392392
sfInHcModel = Unified //floor inside film coefficient
393-
sfExH=100000 //floor outside film coefficient
394-
sfExHcModel = Unified
393+
sfExHcMult=100000 //floor outside film coefficient
394+
sfExHcModel = INPUT
395395

396396
SURFACE North_Wall
397397
sfType=Wall

test/CRTerminalAH.cse

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -191,7 +191,8 @@ ZONE Z1
191191
sfExT=50 //10 C ground temperature
192192
sfInAbs=INABSORP
193193
sfInHcModel = Unified //floor inside film coefficient
194-
sfExH=100000 //floor outside film coefficient
194+
sfExHcMult=100000 //floor outside film coefficient
195+
sfExHcModel = INPUT
195196
sfModel = SFMODELX
196197

197198
SURFACE North_Wall

test/Zonetest4W.cse

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ MATERIAL "stucco" matCond=0.4167 matSpHt=0.2 matDens=116. // JA
3535

3636
//Constructions
3737

38-
CONSTRUCTION WCav13 // �W.13.2X4 BAW 9/2
38+
CONSTRUCTION WCav13 // �W.13.2X4 BAW 9/2
3939
layer lrMat="Gypbd" lrThk=0.25/12.
4040
layer lrMat="Gypbd" lrThk=0.25/12.
4141
layer lrMat="R11" lrThk=3.5/(12.*2)
@@ -153,16 +153,16 @@ Zone Single znArea=100 znCAir=18.3 infAC=0 infShld=5 infStories=1 infELA=0 znVol
153153
znQMxH = 1000000 znQMxC = -500000 //
154154
GAIN gnPower= select( $hour >12,0.,default 0.0) gnFrRad=0 //
155155

156-
SURFACE "North" sfType=Wall sfCon=WCav13 sfArea=10 sfAzm=Front sfExAbs=0. sfModel = forward_difference sfExCnd=SPECIFIEDT sfExT=70 sfExH=1.5 //
157-
SURFACE "South" sfType=Wall sfCon=WCav13 sfArea=100 sfAzm=Back sfExAbs=0. sfModel = forward_difference sfExCnd=SPECIFIEDT sfExT=70 sfExH=1.5 //
156+
SURFACE "North" sfType=Wall sfCon=WCav13 sfArea=10 sfAzm=Front sfExAbs=0. sfModel = forward_difference sfExCnd=SPECIFIEDT sfExT=70 sfExHcMult=1.5 sfExHcModel=INPUT//
157+
SURFACE "South" sfType=Wall sfCon=WCav13 sfArea=100 sfAzm=Back sfExAbs=0. sfModel = forward_difference sfExCnd=SPECIFIEDT sfExT=70 sfExHcMult=1.5 sfExHcModel=INPUT//
158158

159159
#redefine WinU 0.4 // Window NFRC U-factor
160-
WINDOW wnHeight=10; wnWidth=5 wnGt=GT wnSMSO=0.; wnSMSC=0.; wnU=(1./((1./WinU)-0.85)) wnInH=1.5 // BAW 10/17
160+
WINDOW wnHeight=10; wnWidth=5 wnGt=GT wnSMSO=0.; wnSMSC=0.; wnU=(1./((1./WinU)-0.85)) wnExHcMult=1.5 wnExHcModel=INPUT // BAW 10/17
161161

162-
SURFACE "East" sfType=Wall sfCon=WCav13 sfArea=100 sfAzm=Back sfExAbs=0. sfModel = forward_difference sfExCnd=SPECIFIEDT sfExT=70 sfExH=1.5
163-
SURFACE "West" sfType=Wall sfCon=WCav13 sfArea=100 sfAzm=right sfExAbs=0. sfModel = forward_difference sfExCnd=SPECIFIEDT sfExT=70 sfExH=1.5 //
164-
SURFACE "Ceil" sfType=Ceiling sfCon=WCav13 sfArea=100 sfExAbs=0. sfModel = forward_difference sfExCnd=SPECIFIEDT sfExT=70 sfExH=1.5 //
165-
SURFACE "Floor" sfType=Floor sfCon=WCav13 sfArea=100 sfExAbs=0. sfModel = forward_difference sfExCnd=SPECIFIEDT sfExT=70 sfExH=1.5 //
162+
SURFACE "East" sfType=Wall sfCon=WCav13 sfArea=100 sfAzm=Back sfExAbs=0. sfModel = forward_difference sfExCnd=SPECIFIEDT sfExT=70 sfExHcMult=1.5 sfExHcModel=INPUT
163+
SURFACE "West" sfType=Wall sfCon=WCav13 sfArea=100 sfAzm=right sfExAbs=0. sfModel = forward_difference sfExCnd=SPECIFIEDT sfExT=70 sfExHcMult=1.5 sfExHcModel=INPUT//
164+
SURFACE "Ceil" sfType=Ceiling sfCon=WCav13 sfArea=100 sfExAbs=0. sfModel = forward_difference sfExCnd=SPECIFIEDT sfExT=70 sfExHcMult=1.5 sfExHcModel=INPUT//
165+
SURFACE "Floor" sfType=Floor sfCon=WCav13 sfArea=100 sfExAbs=0. sfModel = forward_difference sfExCnd=SPECIFIEDT sfExT=70 sfExHcMult=1.5 sfExHcModel=INPUT//
166166

167167
// SURFACE "IExSlab" UseType "IntExpSlab" sfArea=100
168168

test/actest1bL.cse

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,7 @@ MATERIAL "Crawl" matThk=1. matCond=1./6. matSpHt=.24 ma
9999
MATERIAL "SoftWood" matCond=0.98/12 matSpHt=.39 matDens=35. // 2009 HOF 26.6 Douglas fir/larch
100100
MATERIAL "Concrete" matCond=1. matSpHt=0.2 matDens=144.
101101
//MATERIAL "Sheath" matThk=1./12. matCond=1./(12*Rval) matSpHt=.35 matDens=1.5 // R4 from 2009 HOF 26.6
102-
//MATERIAL "BlownInsul" matCond=0.032051282/RCQ matSpHt=.2 matDens=0.5 // Certainteed InsulSafe�SP Fiber Glass R=2.6/in for R30-38
102+
//MATERIAL "BlownInsul" matCond=0.032051282/RCQ matSpHt=.2 matDens=0.5 // Certainteed InsulSafe�SP Fiber Glass R=2.6/in for R30-38
103103
MATERIAL "BlownInsul" matCond=0.032051282/RCQ matSpHt=.2 matDens=0.5 matCondCT =0.00418 // variable k
104104

105105

@@ -673,13 +673,13 @@ Zone Single znArea=1000 infAC=0 infShld=4 infStories=1 infELA=0 znVol = 9000 znE
673673
znRSYS = MySys //BAW 120312
674674
//znQMxHRated = 1000000 znQMxCRated = -1000000 znQMxH =1000000 znQMxC = -1000000
675675
znModel = CZM znTH = 70 znTD = 74 znTC = 78
676-
SURFACE Wall1 sfType=Wall sfArea=300 sfCon=CondSurf; sfAZM=0 sfExCnd=SPECIFIEDT sfModel = FD sfLThkF=LFact sfInHcModel=Input sfExAbs=0 sfExT=OutT sfexEpsLW=0.
677-
SURFACE Wall2 sfType=Wall sfArea=300 sfCon=CondSurf; sfAZM=0 sfExCnd=SPECIFIEDT sfModel = FD sfLThkF=LFact sfInHcModel=Input sfExAbs=0 sfExT=OutT sfexEpsLW=0.
678-
SURFACE Wall3 sfType=Wall sfArea=300 sfCon=CondSurf; sfAZM=0 sfExCnd=SPECIFIEDT sfModel = FD sfLThkF=LFact sfInHcModel=Input sfExAbs=0 sfExT=OutT sfexEpsLW=0.
679-
SURFACE Wall4 sfType=Wall sfArea=300 sfCon=CondSurf; sfAZM=0 sfExCnd=SPECIFIEDT sfModel = FD sfLThkF=LFact sfInHcModel=Input sfExAbs=0 sfExT=OutT sfexEpsLW=0.
676+
SURFACE Wall1 sfType=Wall sfArea=300 sfCon=CondSurf; sfAZM=0 sfExCnd=SPECIFIEDT sfModel = FD sfLThkF=LFact sfInHcModel=Input sfExAbs=0 sfExT=OutT sfexEpsLW=0. sfExHcModel = INPUT sfExHcMult = 2.64
677+
SURFACE Wall2 sfType=Wall sfArea=300 sfCon=CondSurf; sfAZM=0 sfExCnd=SPECIFIEDT sfModel = FD sfLThkF=LFact sfInHcModel=Input sfExAbs=0 sfExT=OutT sfexEpsLW=0. sfExHcModel = INPUT sfExHcMult = 2.64
678+
SURFACE Wall3 sfType=Wall sfArea=300 sfCon=CondSurf; sfAZM=0 sfExCnd=SPECIFIEDT sfModel = FD sfLThkF=LFact sfInHcModel=Input sfExAbs=0 sfExT=OutT sfexEpsLW=0. sfExHcModel = INPUT sfExHcMult = 2.64
679+
SURFACE Wall4 sfType=Wall sfArea=300 sfCon=CondSurf; sfAZM=0 sfExCnd=SPECIFIEDT sfModel = FD sfLThkF=LFact sfInHcModel=Input sfExAbs=0 sfExT=OutT sfexEpsLW=0. sfExHcModel = INPUT sfExHcMult = 2.64
680680

681-
SURFACE Floor sfType=floor sfArea=900 sfCon=CondSurf; sfExCnd=SPECIFIEDT sfModel = FD sfLThkF=LFact sfInHcModel=Input sfExAbs=0 sfExT=OutT sfexEpsLW=0.
682-
SURFACE Ceil sfType=ceiling sfArea=900 sfCon=CondSurf; sfExCnd=SPECIFIEDT sfModel = FD sfLThkF=LFact sfInHcModel=Input sfExAbs=0 sfExT=OutT sfexEpsLW=0.
681+
SURFACE Floor sfType=floor sfArea=900 sfCon=CondSurf; sfExCnd=SPECIFIEDT sfModel = FD sfLThkF=LFact sfInHcModel=Input sfExAbs=0 sfExT=OutT sfexEpsLW=0. sfExHcModel = INPUT sfExHcMult = 2.64
682+
SURFACE Ceil sfType=ceiling sfArea=900 sfCon=CondSurf; sfExCnd=SPECIFIEDT sfModel = FD sfLThkF=LFact sfInHcModel=Input sfExAbs=0 sfExT=OutT sfexEpsLW=0. sfExHcModel = INPUT sfExHcMult = 2.64
683683
IZXFER CZtran izNVTYPE = AirNetExt izZN1 = Single izALo = 1 izCpr=0. izExp=.65 izHD =1
684684

685685
Run

0 commit comments

Comments
 (0)