Skip to content

Commit d18b13c

Browse files
committed
Code out unused conditionally-compiled code; improve DHWSYSRES comments in cnrecs.def
1 parent cf92797 commit d18b13c

File tree

2 files changed

+21
-35
lines changed

2 files changed

+21
-35
lines changed

src/CNRECS.DEF

Lines changed: 21 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -4026,42 +4026,31 @@ RECORD DHWSYSRES_IVL "DHWSYSRES interval sub" *SUBSTRUCT // interval substruct
40264026
*declare "float wsr_EnergyBalance();"
40274027
*declare "static const size_t wsr_NFLOAT;"
40284028

4029-
#if defined( DHWSYSRES_REV)
40304029
// energy (not fuel) exchanges with water, Btu
4031-
// values are for associated DHWSYS (wh_mult included, ws_mult not included)
4030+
// values are for associated DHWSYS (wh_mult(s) included, ws_mult not included)
40324031
// CAUTION: code relies on mbr order, change with care
4033-
*e FLOAT qOutDHW // hot water energy delivered to fixtures (>=0, + = from DHWSYS)
4034-
*e FLOAT qOutHtg // space heating (CHDHW) energy delivered (>=0, + = from DHWSYS)
4035-
*e FLOAT qLossMisc // misc non-loop losses (DHWTANK losses, T24DHW branch losses, <= 0)
4036-
*e FLOAT qLossLoop // DHWLOOP/DHWLOOPBRANCH losses (+ = to DHWSYS, typically <= 0)
4037-
*e FLOAT qDWHR // heat added via drain water heat recovery (DWHR) (+ = to DHWSYS, >= 0)
4038-
*e FLOAT qSSF // implied energy contribution from ws_SSF (+ = to DHWSYS, >= 0)
4039-
*e FLOAT qSolar // DHWSOLARSYS contribution (+ = to DHWSYS, >= 0)
4040-
*e *array 2 FLOAT qPrimary // DHWHEATER primary heat added (compressor, burner, resistance; + = to DHWSYS, >= 0)
4041-
*e *array 2 FLOAT qAux // DHWHEATER aux heat added (resistance if any), + = to DHWSYS, >= 0)
4042-
*e *array 2 FLOAT qLoss // DHWHEATER tank loss (HPWH types only, + = to DHWSYS, typically <= 0)
4043-
*e *array 2 FLOAT qStorage // DHWHEATER change in tank heat content, + = increase in tank temp
4044-
*e *array 2 FLOAT qError // DHWHEATER heat balance error (internal to HPWH)
4045-
// included in DHWSYS balance to hide HPWH unbalance
4032+
*e FLOAT qOutDHW // hot water energy delivered to fixtures, Btu (>=0, + = from DHWSYS)
4033+
*e FLOAT qOutHtg // space heating (CHDHW) energy delivered, Btu (>=0, + = from DHWSYS)
4034+
*e FLOAT qLossMisc // misc non-loop losses, Btu (DHWTANK losses, T24DHW branch losses, <= 0)
4035+
*e FLOAT qLossLoop // DHWLOOP/DHWLOOPBRANCH losses, Btu (+ = to DHWSYS, typically <= 0)
4036+
*e FLOAT qDWHR // heat added via drain water heat recovery (DWHR), Btu (+ = to DHWSYS, >= 0)
4037+
*e FLOAT qSSF // implied energy contribution from ws_SSF, Btu (+ = to DHWSYS, >= 0)
4038+
*e FLOAT qSolar // DHWSOLARSYS contribution, Btu (+ = to DHWSYS, >= 0)
4039+
*e *array 2 FLOAT qPrimary // DHWHEATER [0] or DHWLOOPHEATER [1] primary heat added, Btu
4040+
// (compressor, burner, resistance; + = to DHWSYS, >= 0)
4041+
*e *array 2 FLOAT qAux // DHWHEATER [0] or DHWLOOPHEATER [1] in-tank aux heat added, Btu
4042+
// (HPWH types only, + = to DHWSYS, >= 0)
4043+
*e *array 2 FLOAT qLoss // DHWHEATER [0] or DHWLOOPHEATER [1] tank loss, Btu
4044+
// (HPWH types only, + = to DHWSYS, typically <= 0)
4045+
*e *array 2 FLOAT qStorage // DHWHEATER [0] or DHWLOOPHEATER [1] change in tank heat content, Btu
4046+
// (HPWH types only, + = increase in tank temp)
4047+
*e *array 2 FLOAT qError // DHWHEATER [0] or DHWLOOPHEATER [1] HPWH internal heat balance error, Btu
4048+
// included in DHWSYSRES balance to hide HPWH unbalance
40464049
// pending investigation 5/2022
4047-
*e FLOAT qXBUDHW // backup heating allocated to DHW (+ = to DHWSYS, >= 0)
4048-
*e FLOAT qXBUHtg // backup heating allocated to space heating (+ = to DHWSYS, >= 0)
4049-
*e FLOAT qBal // sum of energy flows = (qOutDHW + qOutHtg) - Sum( everything else)
4050+
*e FLOAT qXBUDHW // extra backup heating allocated to DHW, Btu (+ = to DHWSYS, >= 0)
4051+
*e FLOAT qXBUHtg // extra backup heating allocated to space heating, Btu (+ = to DHWSYS, >= 0)
4052+
*e FLOAT qBal // sum of energy flows, Btu = (qOutDHW + qOutHtg) - Sum( everything else)
40504053
// s/b 0; >=0 means more output than input
4051-
#else
4052-
// water heating energy (not fuel), Btu
4053-
// values are for associated DHWSYS (wh_mult include, ws_mult not included)
4054-
*e FLOAT qLoad // hot water load (heat delivered to fixtures)
4055-
*e FLOAT qLoss // non-loop losses (jacket losses, T24DHW branch losses, )
4056-
*e FLOAT qLoop // DHWLOOP/DHWLOOPBRANCH losses
4057-
*e FLOAT qCHDHW // space heating energy, nz iff combined heat/DHW
4058-
*e FLOAT qDWHR // drain water heat recovery
4059-
*e FLOAT qSSF // implied energy contribution from ws_SSF
4060-
*e FLOAT qSolar // DHWSOLARSYS
4061-
*e FLOAT qWH // DHWHEATER primary (compressor, burner, )
4062-
*e FLOAT qLH // Loop heater primary
4063-
*e FLOAT qXBU // add'l backup heat
4064-
#endif
40654054

40664055
*END // DHWSYSRES_IVL
40674056
//=============================================================================

src/cndefns.h

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -257,9 +257,6 @@
257257
#define DIM_SUBMETERLIST 51 // dimension of submeter lists in MTR, LOADMTR,
258258
// max # submeters inputable = DIM_SUBMETERLIST-1
259259

260-
#define DHWSYSRES_REV // define to enable revised DHWSYSRES accounting
261-
// 4-20-2023
262-
263260
#endif // ifndef _CNDEFNS_H
264261

265262
// cndefns.h end

0 commit comments

Comments
 (0)