Fix ACPMCOMBINEDHEATDHW; RSYS PERFORMANCEMAP documentation"

Author: chipbarnaby

doc/src/cse-user-manual.yaml

@@ -79,7 +79,7 @@ sections:
   - [2, "records/doas.md"]
   - [2, "records/rsys.md"]
   - [2, "records/ductseg.md"]
-  - [2, "records/perfmap.md"]
+  - [2, "records/performancemap.md"]
   - [2, "records/dhwdayuse.md"]
   - [2, "records/dhwuse.md"]
   - [2, "records/dhwsys.md"]

doc/src/records/perfmap.md renamed to doc/src/records/performancemap.md

@@ -29,13 +29,15 @@ ASHPHYDRONIC, Air-to-water heat pump with hydronic distribution. Compressor perf
 ASHPPM, Air-to-air heat pump modeled per PERFORMANCMAPs specified via rsPerfMapHtg and rsPerfMapClg.
 WSHP,  Water-to-air heat pump.
 AC, Compressor-based cooling; no heating. Required ratings are SEER and capacity and EER at 95 ^o^F outdoor dry bulb.
+ACPM, Compressor-based cooling modeled per PERFORMANCEMAP specified in rsPerfMapClg; no heating.
 ACPKGROOM, Packaged compressor-based cooling; no heating. Required ratings are capacity and EER at 95 ^o^F outdoor dry bulb.
 FURNACE,  Fuel-fired heating. Primary heating input energy is accumulated to end use HTG of meter rsFuelMtr.
 RESISTANCE,  Electric heating. Primary heating input energy is accumulated to end use HTG of meter rsElecMtr.
 ACPKGROOMFURNACE, Packaged room cooling and (separate) furnace heating.
 ACPKGROOMRESISTANCE, Packaged room cooling and electric resistance heating.
 COMBINEDHEATDHW,  Combined heating / DHW.  Use rsCHDHWSYS to specify the DHWSYS that provides hot water to the coil in this RSYS.  No cooling.
-ACCOMBINEDHEATDHW, Compressor-based cooling plus COMBINEDHEATDHW heating.
+ACCOMBINEDHEATDHW, Compressor-based cooling; COMBINEDHEATDHW heating.
+ACPMCOMBINEDHEATDHW, Compressor-based cooling modeled per PERFORMANCEMAP specified in rsPerfMapClg; COMBINEDHEATDHW heating.
 FANCOIL, Coil-based heating and cooling.  No primary (fuel-using) equipment is modeled.  rsLoadMtr, rsHtgLoadMtr, and rsClgLoadMtr are typically used to record loads for linking to an external model.
 END
 %>
@@ -182,7 +184,7 @@ DHWSYS hot water source for this RSYS, required when rsType is COMBINEDHEATDHW o
 
 <%= member_table(
   units: "",
-  legal_range: "Name of DHWSYS",
+  legal_range: "Name of a DHWSYS",
   default: "*none*",
   required: "if combined heat/DHW",
   variability: "constant") %>
@@ -369,8 +371,26 @@ For WSHP only: ratio of rsCapC to rsCapH.  Used to derive capacity during autosi
 
 **rsPerfMapHtg=*performanceMapName***
 
+Specifies the heating performance PERFORMANCEMAP for RSYSs having rsType=ASHPPM.  The PERFORMANCEMAP must have grid variables outdoor drybulb and compressor speed (in that order) and lookup values of net capacity ratios and COP.  See example in PERFORMANCEMAP.
+
+<%= member_table(
+  units: "",
+  legal_range: "Name of a PERFORMANCEMAP",
+  default: "",
+  required: "if rsType specifies a performance map model",
+  variability: "Start of a run") %>
+
 **rsPerfMapClg=*performanceMapName***
 
+Specifies the cooling performance PERFORMANCEMAP for RSYSs having rsType=ASHPPM, ACPM, ACPMFURNACE, ACPMRESISTANCE, or ACPMCOMBINEDHEATDHW.  The PERFORMANCEMAP must have grid variables outdoor drybulb and compressor speed (in that order) and lookup values of net capacity ratios and COP.  See example in PERFORMANCEMAP.
+
+<%= member_table(
+  units: "",
+  legal_range: "Name of a PERFORMANCEMAP",
+  default: "",
+  required: "if rsType specifies a performance map model",
+  variability: "Start of a run") %>
+
 **rsTypeAuxH=*choice***
 
 For rsType=ASHP, type of auxiliary heat.  Auxiliary heating is used when heatpump capacity is insufficient to maintain zone temperature and during reverse-cycle defrost operation (if rsDefrostModel=REVCYCLEAUX).  If rsTypeAuxH=Furnace, energy use for auxiliary heat is accumulated to end use HPBU of meter rsFuelMtr (if specified).  If rsTypeAuxH=Resistance, energy use for auxiliary heat is accumulated to end use HPBU of meter rsElecMtr (if specified).

doc/src/records/rsys.md

@@ -3453,9 +3453,11 @@ RECORD RSYS "RSYS" *RAT	// residential HVAC system
 *declare "int rs_IsASHPHydronic() const { return rs_type == C_RSYSTY_ASHPHYD; }"
 *declare "bool rs_IsWSHP() const { return rs_type == C_RSYSTY_WSHP; }"
 *declare "bool rs_IsHP() const { return rs_IsASHP() || rs_IsWSHP(); }"
-*declare "bool rs_IsPMHtg() const { return rs_IsASHPPM() || rs_IsCHDHW(); }"
+*declare "bool rs_IsPMHtg() const { return rs_IsASHPPM(); }"
 *declare "bool rs_IsPMClg() const { return rs_IsASHPPM() || rs_type==C_RSYSTY_ACPM || rs_type==C_RSYSTY_ACPMFURN || rs_type==C_RSYSTY_ACPMRES || rs_type == C_RSYSTY_ACPMCHDHW; }"
-*declare "bool rs_IsVC() const { return rs_IsPMHtg() || rs_IsPMClg(); }"
+*declare "bool rs_IsVCHtg() const { return rs_IsPMHtg() || rs_IsCHDHW(); }"
+*declare "bool rs_IsVCClg() const { return rs_IsPMClg(); }"
+*declare "bool rs_IsVC() const { return rs_IsVCHtg() || rs_IsVCClg(); }"
 *declare "bool rs_IsVCMode( int rsMode) const { return rsMode==rsmHEAT ? rs_IsPMHtg() : rsMode==rsmCOOL ? rs_IsPMClg() : false; }"
 *declare "bool rs_IsFanCoil() const { return rs_type == C_RSYSTY_FANCOIL; }"
 *declare "bool rs_IsCHDHW() const { return rs_type == C_RSYSTY_CHDHW || rs_type == C_RSYSTY_ACCHDHW || rs_type == C_RSYSTY_ACPMCHDHW; }"

src/CNRECS.DEF

@@ -3532,17 +3532,20 @@ RC RSYS::rs_SetupCapC(		// derive constants that depend on capacity
 
 		if (rs_Is1Spd())
 		{
-			// base value for SEERnf and EERnf calculations
-			//   used only for single speed
+			// ratings for 82 F and 115 F (reporting only)
 			float SHR = CoolingSHR(82.f, 80.f, 67.f, 400.f);
-			float capF = CoolingCapF1Spd(SHR, 82.f, 80.f, 67.f, 400.f);
-
-			float inpFSEER;
-			float inpFEER = CoolingInpF1Spd(SHR, 82.f, 80.f, 67.f, 400.f, inpFSEER);
-
-			rs_cap82 = capF * rs_cap95;
+			rs_cap82 = rs_cap95 * CoolingCapF1Spd(SHR, 82.f, 80.f, 67.f, 400.f);
 			rs_COP82 = rs_SEER / 3.413f;
+			
+			SHR = CoolingSHR(115.f, 80.f, 67.f, 400.f);
+			rs_cap115 = rs_cap95 * CoolingCapF1Spd(SHR, 115.f, 80.f, 67.f, 400.f);
+			float inpFSEER;
+			float inpFEER = CoolingInpF1Spd(SHR, 115.f, 80.f, 67.f, 400.f, inpFSEER);
+			float inp115 = inpFEER * rs_cap95 / (rs_EER95/3.413f);
+			rs_COP115 = rs_cap115 / inp115;
 
+			// base value for SEERnf and EERnf calculations
+			//   used only for single speed
 			float inpX = 1.09f * rs_cap95 / rs_SEER - rs_fanHRtdC / 3.413f;	// input power, W
 			rs_SEERnfX = inpX > 0.f ? rs_fChg * (1.09f * rs_cap95 + rs_fanHRtdC) / inpX
 				: rs_SEER;
@@ -4604,7 +4607,7 @@ RC RSYS::rs_SetupASHP()		// set ASHP defaults and derived parameters
 		? 0.f
 		: rs_FanPwrRated(0, rs_cap47, PMSPEED::RATED);
 
-	if (!rs_IsPMHtg())
+	if (!rs_IsVCHtg())
 	{	// capacities
 		if (!IsSet(RSYS_CAP17) || rs_IsPkgRoom())
 			rs_cap17 = max(rs_CapRat1747()*rs_cap47, 1.f);
@@ -4935,15 +4938,17 @@ RC RSYS::rs_SetRatingsVCClg()		// derive cooling ratings
 	RC rc = RCOK;
 
 	if (rs_IsPMClg())
-	{	rc |= rs_pPMACCESS[1]->pa_GetRatedCapCOP(82.f, rs_cap82, rs_COP82);
+	{	float cap;	// temporary for return values
+		
+		rc |= rs_pPMACCESS[1]->pa_GetRatedCapCOP(82.f, cap, rs_COP82);
+		rs_cap82 = abs(cap);
 
-		float cap95;
-		rc |= rs_pPMACCESS[1]->pa_GetRatedCapCOP(95.f, cap95, rs_COP95);
+		rc |= rs_pPMACCESS[1]->pa_GetRatedCapCOP(95.f, cap, rs_COP95);
 		rs_EER95 = rs_COP95 * BtuperWh;
+		rc |= rs_CheckPMRatingConsistency(rs_cap95, abs( cap), "cap95", rs_perfMapClgi);
 
-		rc |= rs_pPMACCESS[1]->pa_GetRatedCapCOP(115.f, rs_cap115, rs_COP115);
-
-		rc |= rs_CheckPMRatingConsistency(rs_cap95, abs( cap95), "cap95", rs_perfMapClgi);
+		rc |= rs_pPMACCESS[1]->pa_GetRatedCapCOP(115.f, cap, rs_COP115);
+		rs_cap115 = abs(cap);
 
 	}
 	else
@@ -4953,13 +4958,14 @@ RC RSYS::rs_SetRatingsVCClg()		// derive cooling ratings
 
 }	// RSYS::rs_SetRatingsVCClg
 //-----------------------------------------------------------------------------
-RC RSYS::rs_CheckPMRatingConsistency(
+RC RSYS::rs_CheckPMRatingConsistency(	// verify performance map <-> rating consistency
 	float ratingExp,	// expected value
 	float ratingPM,		// value generated from performance map
 	const char* what,	// name of rating, e.g. "cap47"
 	TI iPM) const		// source performance map
+// returns RCOK iff performance map generated value matches expected
+//    else nz (performance map not correctly normalized?)
 {
-
 	RC rc = RCOK;
 
 	if (frDiff(ratingPM, ratingExp) > 0.001f)
@@ -4972,7 +4978,6 @@ RC RSYS::rs_CheckPMRatingConsistency(
 	}
 
 	return rc;
-
 }		// RSYS::rs_CheckPMRatingConsistency
 //-----------------------------------------------------------------------------
 float RSYS::rs_CapEffASHP(			// performance at current conditions
@@ -5341,7 +5346,7 @@ void RSYS::rs_SetSpeedFMin()		// determine current minimum speedF
 {
 	if (rs_mode == rsmOFF)
 		rs_speedFMin = 0.f;
-	else if (!rs_IsCHDHW())
+	else if (!(rs_IsCHDHW() && rs_mode==rsmHEAT))
 	{
 		if (rs_IsVCMode(rs_mode))
 			rs_speedFMin = rs_pPMACCESS[rs_mode == rsmCOOL]->pa_GetSpeedFMin();

src/cnloads.cpp

@@ -7128,6 +7128,30 @@ ALTER DHWSYS "HWSYS"
           hourval(.50,.50,.50,.50,.50,.50,.50,.30,.95,.95,.95,.95,.95,.95,.95,.95,.95,.50,.50,.50,.50,.50,.50,.50),
         default
           hourval(.15,.15,.15,.15,.15,.15,.15,.15,.15,.15,.15,.15,.15,.60,.60,.60,.15,.15,.15,.15,.15,.15,.15,.15))
+
+ALTER RSYS "rsys1" rsType=ACPMCOMBINEDHEATDHW rsPerfMapClg = "PMClg"
+
+PERFORMANCEMAP "PMClg"
+
+    PMGRIDAXIS "ClgDBT" pmGXType = "DBT" pmGXValues = 60, 82, 95, 115 pmGXRefValue = 95
+    PMGRIDAXIS "ClgSpeed" pmGXType = "Speed" pmGXValues = 1, 2, 3 pmGXRefValue = 2
+
+    // Capacity ratio = net total capacity / net rated total capacity
+    PMLOOKUPDATA LUClgCapRat pmLUType = "CapRat" pmLUValues =
+      0.48, 1.13, 1.26,   // 60F at min, mid, max speed
+      0.42, 1.05, 1.17,   // 82F
+      0.39, 1.00, 1.12,   // 95F
+      0.34, 0.92, 1.04    // 115F
+
+    // COP = net total COP
+    PMLOOKUPDATA LUClgCOP pmLUType = "COP" pmLUValues =
+      14.22, 16.44, 15.00,   // 60F at min, mid, max speed
+       7.93,  7.59,  6.71,   // 82F
+       6.01,  5.58,  4.91,   // 95F
+       4.12,  3.82,  3.34    // 115F
+
+endPERFORMANCEMAP
+
 RUN