Table Form Fixes

[naasanov]

Motivation

There are several small issues with the Create & Edit forms for admin/staff. This ticket should clean up the rough edges with this feature.

Deliverables

Fix the following issues

• Phone number regex is not checked on client side, should match the backend regex (party, student)
• Many forms do not show the error dialog for server issues (not founds, conflicts, etc.)
  • This is confirmed for edit party and create location, but should be checked for all forms
  • Some will error but look like they succeeded (confirmed for create student but could exist for others). This is likely due to over-optimistic rendering with react query. Feel free to just remove the offending optimistic rendering. There will be a future ticket which will be focused on implementing optimistic rendering in all relevant queries.
• Many error dialogs are not descriptive (e.g. “Failed to create party: Failed to create party”)
  • Status codes should be mapped to descriptive error messages
• In edit forms, the address is not pre-loaded into the address search component correctly (party, location)
• For forms with optional (nullable) fields, it should be made clear that these fields are optional somehow (student : last registered, location : hold expiration date, and any others)
• Email and PID fields should be made non-editable in edit forms (student, account)
  • This is because these fields are decided by SSO, so editing them would cause problems.
  • They are kept in create forms for extraneous situations
  • In editing forms, the field should still be there with the data visible, but have the input disabled
  • Suggestion: Could implement this by checking if editData is non-null, and disabling inputs if so

Important Notes

• A lot of these errors are from integration with react query which was implemented during HackDay, so issues were expected