Skip to content

Incidents Backend Refactor #164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
naasanov merged 2 commits into from
Jan 31, 2026
Merged

Incidents Backend Refactor #164

naasanov merged 2 commits into from
Jan 31, 2026

Conversation

@aLEGEND21
Copy link
Collaborator

@aLEGEND21 aLEGEND21 commented Jan 27, 2026

The current system tracks complaints as their own table while warnings and citations are stored as integer counters on the Location entity. This creates inconsistency in how we track incidents and makes it difficult to view the history or details of individual warnings/citations. This PR consolidates all three incident types into a single Incidents table with a severity field.

Changes:

New Incident Module

  • Added incident_entity.py, incident_model.py, incident_service.py, and incident_router.py to replace the complaint module
  • Added IncidentSeverity enum with values: complaint, warning, citation
  • Added severity field to incident data model and entity

Location Entity Updates

  • Removed warning_count and citation_count columns since these are now derived from the incidents table
  • Renamed complaints relationship to incidents
  • Updated LocationDto to return incidents list instead of complaints
  • Removed MAX_COUNT constant and count validation logic

Removed Increment Routes

  • Deleted POST /api/police/locations/{id}/warnings and POST /api/police/locations/{id}/citations endpoints
  • Deleted the now-empty police_router.py since police credential routes live in account_router.py
  • Deleted increment_warnings() and increment_citations() methods from LocationService

Test Updates

  • Created new incident test files (incident_utils.py, incident_service_test.py, incident_router_test.py)
  • Updated location tests to use incidents instead of complaints and removed count-related tests
  • Deleted complaint test files and police router tests

Script Updates

  • Updated reset_dev.py to remove warning_count and citation_count from location seeding

Cursor was helpful with making these changes, but I reviewed all AI-made changes prior to committing the code.

Closes #127

@aLEGEND21 aLEGEND21 requested a review from naasanov January 27, 2026 19:34
@github-actions
Copy link

github-actions bot commented Jan 27, 2026 •
edited
Loading

Test Results Summary

293 tests   - 9   293 ✅  - 9   11s ⏱️ ±0s
  1 suites ±0     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit 33cd7dc. ± Comparison against base commit c972c7c.

This pull request removes 44 and adds 35 tests. Note that renamed tests count towards both. 
test.modules.complaint.complaint_router_test ‑ test_complaint_authentication[allowed_roles0-GET-/api/locations/1/complaints-None]
test.modules.complaint.complaint_router_test ‑ test_complaint_authentication[allowed_roles1-POST-/api/locations/1/complaints-body1]
test.modules.complaint.complaint_router_test ‑ test_complaint_authentication[allowed_roles2-PUT-/api/locations/1/complaints/1-body2]
test.modules.complaint.complaint_router_test ‑ test_complaint_authentication[allowed_roles3-DELETE-/api/locations/1/complaints/1-None]
test.modules.complaint.complaint_router_test.TestComplaintRouter ‑ test_create_complaint_location_id_required
test.modules.complaint.complaint_router_test.TestComplaintRouter ‑ test_create_complaint_success
test.modules.complaint.complaint_router_test.TestComplaintRouter ‑ test_create_complaint_with_empty_description
test.modules.complaint.complaint_router_test.TestComplaintRouter ‑ test_delete_complaint_not_found
test.modules.complaint.complaint_router_test.TestComplaintRouter ‑ test_delete_complaint_success
test.modules.complaint.complaint_router_test.TestComplaintRouter ‑ test_get_complaints_by_location_empty
…

test.modules.incident.incident_router_test ‑ test_incident_authentication[allowed_roles0-GET-/api/locations/1/incidents-None]
test.modules.incident.incident_router_test ‑ test_incident_authentication[allowed_roles1-POST-/api/locations/1/incidents-body1]
test.modules.incident.incident_router_test ‑ test_incident_authentication[allowed_roles2-PUT-/api/locations/1/incidents/1-body2]
test.modules.incident.incident_router_test ‑ test_incident_authentication[allowed_roles3-DELETE-/api/locations/1/incidents/1-None]
test.modules.incident.incident_router_test.TestIncidentRouter ‑ test_create_incident_severity_required
test.modules.incident.incident_router_test.TestIncidentRouter ‑ test_create_incident_success
test.modules.incident.incident_router_test.TestIncidentRouter ‑ test_create_incident_with_empty_description
test.modules.incident.incident_router_test.TestIncidentRouter ‑ test_create_incident_with_severity
test.modules.incident.incident_router_test.TestIncidentRouter ‑ test_delete_incident_not_found
test.modules.incident.incident_router_test.TestIncidentRouter ‑ test_delete_incident_success
…

♻️ This comment has been updated with latest results.

@aLEGEND21 aLEGEND21 changed the title refactor: Store warnings/complaints as a separate Incident table Incidents Backend Refactor Jan 27, 2026
naasanov
naasanov requested changes Jan 30, 2026
View reviewed changes
Copy link
Collaborator

@naasanov naasanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, just a couple changes

naasanov
naasanov requested changes Jan 30, 2026
View reviewed changes
@aLEGEND21 aLEGEND21 requested a review from naasanov January 31, 2026 05:40
naasanov
naasanov approved these changes Jan 31, 2026
View reviewed changes
Copy link
Collaborator

@naasanov naasanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@naasanov naasanov merged commit 571a307 into main Jan 31, 2026
2 checks passed
@naasanov naasanov deleted the arnav/incidents-backend-refactor branch January 31, 2026 21:46
VidurShah pushed a commit that referenced this pull request Feb 2, 2026
@aLEGEND21 @VidurShah
Incidents Backend Refactor (#164)
6b30ffc 
* refactor: Store warnings/complaints as a separate Incident table

* refactor: Couple of minor changes that were requested
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@naasanov naasanov naasanov approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Incidents Backend Refactor

3 participants

@aLEGEND21 @naasanov