From 4554450c1f40112c6063700169cc1933f9399d15 Mon Sep 17 00:00:00 2001 From: ThatMegamind Date: Wed, 1 May 2024 12:32:55 -0700 Subject: [PATCH] fixed season retrieval for stat modal --- common/utils.js | 18 +++++++++++++++++- routes/publishedSchedule.js | 15 +++++++++++---- 2 files changed, 28 insertions(+), 5 deletions(-) diff --git a/common/utils.js b/common/utils.js index 2ba4fef..76a57a4 100644 --- a/common/utils.js +++ b/common/utils.js @@ -110,4 +110,20 @@ const getSeasonFromMonthAndYear = (month, year) => { return `Fall ${year}`; }; -module.exports = { keysToCamel, isInteger, calculateYear, getSeasonFromMonthAndYear }; +const getMonthRangeFromSeason = (season) => { + if (season === 'spring') { + return [0, 4]; + } + if (season === 'summer') { + return [5, 7]; + } + return [8, 12]; +}; + +module.exports = { + keysToCamel, + isInteger, + calculateYear, + getSeasonFromMonthAndYear, + getMonthRangeFromSeason, +}; diff --git a/routes/publishedSchedule.js b/routes/publishedSchedule.js index 5747bff..a0ba8f3 100644 --- a/routes/publishedSchedule.js +++ b/routes/publishedSchedule.js @@ -1,6 +1,11 @@ const express = require('express'); const { db } = require('../server/db'); -const { keysToCamel, calculateYear, getSeasonFromMonthAndYear } = require('../common/utils'); +const { + keysToCamel, + calculateYear, + getSeasonFromMonthAndYear, + getMonthRangeFromSeason, +} = require('../common/utils'); const publishedScheduleRouter = express.Router(); @@ -221,6 +226,7 @@ publishedScheduleRouter.get('/season', async (req, res) => { publishedScheduleRouter.get('/stats', async (req, res) => { try { const { season, year } = req.query; + const [monthStart, monthEnd] = getMonthRangeFromSeason(season); const statResult = await db.query( ` @@ -249,8 +255,9 @@ publishedScheduleRouter.get('/stats', async (req, res) => { FROM catalog c JOIN published_schedule ps ON c.id = ps.event_id JOIN day d ON PS.day_id = d.id - WHERE $1 = ANY(c.season) - AND EXTRACT(YEAR FROM d.event_date) = $2 + WHERE EXTRACT(MONTH FROM d.event_date) >= $1 + AND EXTRACT(MONTH FROM d.event_date) <= $2 + AND EXTRACT(YEAR FROM d.event_date) = $3 ) c ON ap.event_type = ANY(c.event_type) AND ap.subject = ANY(c.subject) GROUP BY ROLLUP (ap.event_type), ROLLUP (ap.subject) ORDER BY CASE WHEN ap.event_type IS NULL THEN 1 ELSE 0 END, @@ -258,7 +265,7 @@ publishedScheduleRouter.get('/stats', async (req, res) => { ap.event_type NULLS FIRST, ap.subject NULLS FIRST; `, - [season, year], + [monthStart, monthEnd, year], ); res.status(200).json(keysToCamel(statResult));