Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

34 catalog pagination backend #42

Merged
merged 4 commits into from
Feb 6, 2024
Merged

Conversation

h0ethan04
Copy link
Contributor

  • Modified GET request of /catalog to return a JSON object with two keys: count (number of elements in the table) and events (event objects themselves)
  • Added limit and pages parameters to GET request of /catalog route
  • Added isInteger function, a dependency for pagination functionality

Closes #34

@ThatMegamind ThatMegamind linked an issue Feb 5, 2024 that may be closed by this pull request
ThatMegamind
ThatMegamind previously approved these changes Feb 5, 2024
Copy link
Collaborator

@ThatMegamind ThatMegamind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to us!

routes/catalog.js Outdated Show resolved Hide resolved
routes/catalog.js Outdated Show resolved Hide resolved
routes/catalog.js Outdated Show resolved Hide resolved
routes/catalog.js Outdated Show resolved Hide resolved
routes/catalog.js Outdated Show resolved Hide resolved
routes/catalog.js Outdated Show resolved Hide resolved
routes/catalog.js Outdated Show resolved Hide resolved
routes/catalog.js Outdated Show resolved Hide resolved
routes/catalog.js Outdated Show resolved Hide resolved
routes/catalog.js Outdated Show resolved Hide resolved
Copy link
Member

@michellelin1 michellelin1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to us! :)

@michellelin1 michellelin1 merged commit 2434108 into dev Feb 6, 2024
3 checks passed
@michellelin1 michellelin1 deleted the 34-catalog-pagination-backend branch February 6, 2024 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Catalog Pagination (Backend)
5 participants