Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PID file is not customisable #14

Open
tigris opened this issue Nov 15, 2012 · 2 comments
Open

PID file is not customisable #14

tigris opened this issue Nov 15, 2012 · 2 comments

Comments

@tigris
Copy link

tigris commented Nov 15, 2012

I notice in the default redis.conf file it tries to set /var/run/redis/redis_$PORT.pid as the pid file. However, this is never where the PID file ends up. I am using the standard "package" recipe and I'm on ubuntu, so I assume this is just stock standard for the /etc/init.d script that the OS package management puts in place, since it uses start-stop-daemon, it needs to know the location of the pid file.

In any case, I just found it quite confusing that the PID file is customisable in redis, but then never even used.

@tarnfeld
Copy link
Contributor

I've just created a pull request from my fork that has changed the config file to match that of the full redis 2.4.* example. All options are customisable (Except those that are depreciated).

Check it out here until @ctrabold accepts my PR (#13) - https://github.com/tarnfeld/chef-redis

@tarnfeld
Copy link
Contributor

A side note, I successfully upgraded the 0.0.5 version of this cookbook to 0.0.6 in production with little or no downtime (only during the redis restart), it should be a seamless switch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants