Merge pull request #749 from cucumber/issue-699-disable-bundler-using-bundler-tooling-0-14-stable

Disable bundler using bundler tooling (0-14-stable)

Author: mvz

features/03_testing_frameworks/cucumber/disable_bunder.feature

@@ -1,18 +1,51 @@
 Feature: Disable Bundler environment
   Use the @disable-bundler tag to escape from your project's Gemfile.
 
-  Background:
-    Given I use the fixture "cli-app"
-
+  @disable-bundler
   Scenario: Clear the Bundler environment
-
+    Given I use the fixture "cli-app"
     Given a file named "features/run.feature" with:
     """
     Feature: My Feature
       @disable-bundler
       Scenario: Check environment
         When I run `env`
         Then the output should not match /^BUNDLE_GEMFILE=/
+
+      @disable-bundler
+      Scenario: Run bundle in a fresh bundler environment
+        Given a file named "Gemfile" with:
+        \"\"\"
+        source 'https://rubygems.org'
+        \"\"\"
+        When I run `bundle`
+        Then the output should not contain "aruba"
+
+      @disable-bundler
+      Scenario: Run programs that are not in the outer bundle
+        Given a file named "Gemfile" with:
+        \"\"\"
+        source 'https://rubygems.org'
+
+        gem 'rubocop'
+        \"\"\"
+        When I run `bundle`
+        When I run `bundle exec rubocop --help`
+        Then the output should contain "Usage: rubocop"
     """
-    When I run `cucumber`
+    When I run `bundle`
+    When I run `bundle exec cucumber`
     Then the features should all pass
+
+  @disable-bundler
+  Scenario: Direct test
+    Given I use the fixture "cli-app"
+    Given a file named "Gemfile" with:
+    """
+    source 'https://rubygems.org'
+
+    gem 'parallel_tests'
+    """
+    When I successfully run `bundle`
+    When I successfully run `bundle exec parallel_rspec --help`
+    Then the output should contain "Run all tests in parallel"

fixtures/cli-app/Gemfile

@@ -0,0 +1,4 @@
+source 'https://rubygems.org'
+
+# Use dependencies from gemspec
+gemspec

fixtures/cli-app/cli-app.gemspec

@@ -21,6 +21,7 @@ Gem::Specification.new do |spec|
   spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
   spec.require_paths = ['lib']
 
-  spec.add_development_dependency 'bundler', '~> 1.9'
-  spec.add_development_dependency 'rake', '~> 10.0'
+  spec.add_development_dependency 'bundler'
+  spec.add_development_dependency 'rake'
+  spec.add_development_dependency 'aruba'
 end

fixtures/empty-app/cli-app.gemspec

@@ -21,6 +21,6 @@ Gem::Specification.new do |spec|
   spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
   spec.require_paths = ['lib']
 
-  spec.add_development_dependency 'bundler', '~> 1.9'
-  spec.add_development_dependency 'rake', '~> 10.0'
+  spec.add_development_dependency 'bundler'
+  spec.add_development_dependency 'rake'
 end

lib/aruba/api/bundler.rb

@@ -7,8 +7,23 @@ module Bundler
 
       # Unset variables used by bundler
       def unset_bundler_env_vars
-        %w[RUBYOPT BUNDLE_PATH BUNDLE_BIN_PATH BUNDLE_GEMFILE].each do |key|
-          delete_environment_variable(key)
+        empty_env = with_environment { with_unbundled_env { ENV.to_h } }
+        aruba_env = aruba.environment.to_h
+        (aruba_env.keys - empty_env.keys).each do |key|
+          delete_environment_variable key
+        end
+        empty_env.each do |k, v|
+          set_environment_variable k, v
+        end
+      end
+
+      private
+
+      def with_unbundled_env
+        if ::Bundler.respond_to?(:with_unbundled_env)
+          ::Bundler.with_unbundled_env { yield }
+        else
+          ::Bundler.with_clean_env { yield }
         end
       end
     end