-
-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Gherkin syntax highlighters to support Rule keyword #14
Comments
Geany - The Flyweight IDE |
Links to some of these editors/highlighters are here: https://cucumber.io/docs/tools/related-tools/ |
We also have rouge, which I believe is what powers Gitlab. |
IntelliJ support is done via https://youtrack.jetbrains.com/issue/IDEA-199579, I can confirm this is working in the current version (2019.3), and also in:
That's as far as I can confirm with what I have installed, but seems as though all the IDEA tools are covered by the same core plugin. |
I noticed that too @davidjgoss - impressive! |
Oh, so although the Gherkin syntax support (in terms of highlighting and formatting) is fine, the autocompletion is not quite there: Looks like the autocompletion comes from a Cucumber plugin (as opposed to the Gherkin language support) as that's also what drives the autocompletion of steps and jumping between implementation and usage etc. Seems to live here https://github.com/JetBrains/intellij-plugins/tree/master/cucumber/src/org/jetbrains/plugins/cucumber, I might take a run at fixing it later. |
That would be great @davidjgoss! I think the most important thing to fix in that plugin is to recognise cucumber expressions... |
Having looked deeper now, the main cucumber plugin for IDEA does support autocompletion of cucumber-jvm on master is currently on gherkin 5.2.0 but it would be nice to get the plugin primed so it just starts working as soon as people update to whatever version bring gherkin 6+ with it - maybe we can expose the gherkin version in |
I think a better name than |
There are a lot of third-party highlighters out there that people may want to send pull-requests to. In order to make it easy to send new pull requests whenever Gherkin changes, we need some utilities to make it easy to update them. Take pygments for example. We should provide some simple command-line tool (in
Which could output something like this:
|
With the release of Gherkin 8 and Cucumbers using it, various syntax highlighters must be updated to support the new keywords.
A good start is to create issues in these tools' bug trackers. The issues should suggest using gherkin-languages.json to do code-generation. That way the lexers/parsers can be easily updated when new translations are added (or if we make other grammar changes in the future).
I have compiled a list of highlighters/editors below. Please add a comment with a link to the issue/PR if you create one and I will update this list. We'll check the box when an issue is fixed.
Which ones did I forget?
The text was updated successfully, but these errors were encountered: