Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

objective-c: The rule keyword is part of the grammar file but the parser lacks the token for it #23

Open
broken-bytes opened this issue May 31, 2021 · 3 comments

Comments

@broken-bytes
Copy link

broken-bytes commented May 31, 2021

The rule keyword is now part of the grammar file, but the Parser fules are still outdated and lack support for it.

@aslakhellesoy
Copy link
Contributor

We don’t currentøy have a maintainer for the ObjC implementation.

would yoube interested in picking it up? We can give you guidance and support if you need it.

@broken-bytes
Copy link
Author

I would rather take the existing codebase, transfer it to swift and go from there. I only use this parser because of the abstinence of a Swift version.

I would love to help out on that though.

I was just making false assumptions. I thought generating the parser would generate all the files and features, while in fact the generated part is really just the one main handler. This got me confused because there is a new version for it(The gherkin and objc grammar files) but the codebase was outdated.

I can surely work on a swift version of that.

I do have some experience with objective c but not nearly as much as with Swift, that's why I'd prefer to transfer it over to Swift. Plus the fact that Swift is now Apple's main language.

@aslakhellesoy
Copy link
Contributor

Hi @broken-bytes - thanks for offering to help!

It's only the parser that is generated from the grammar. The lexer/scanner and AST builder logic is hand-written.

I realise it might be a bit daunting to become familiar with the ObjC codebase and the build system, but we're here to help. We usually hang out in Slack and we also have weekly committer meetings on Zoom every Thursday at 3pm BST - see the #committers channel for more details.

@mpkorstanje mpkorstanje transferred this issue from cucumber/common Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants