Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement message formatter #341

Open
aslakhellesoy opened this issue Sep 4, 2020 · 3 comments
Open

Implement message formatter #341

aslakhellesoy opened this issue Sep 4, 2020 · 3 comments
Assignees
Labels
⚡ enhancement Request for new functionality

Comments

@aslakhellesoy
Copy link
Contributor

The Cucumber JSON format is deprecated in Cucumber-Ruby, Cucumber-JVM and Cucumber-js. The recommended replacement is cucumber-messages.

It would be great to implement support for this in godog, and deprecate the cucumber formatter (The other Cucumber implementations call it the json formatter).

@aslakhellesoy aslakhellesoy added the ⚡ enhancement Request for new functionality label Sep 4, 2020
@aslakhellesoy
Copy link
Contributor Author

Related issues: #338 #124 #205

@Johnlon
Copy link
Member

Johnlon commented May 2, 2024

@aslakhellesoy (and @dumpsterfireproject ) - I see this ticket is still open - confusingly I can also see that there is a formatter "events" in the code base and I'd assumed initially that the "event" format was the same as the "message" format defined in messages.go and formatted in the jdjson style of cucumer jvm.

BUT the "events" formatter doesn't conform at all to the cucumber/messages definitions in messages.go.

For example

  • there is an event StepDefinitionFound that seems entirely a godog invention.
  • TestStepStarted that is a defined event but godog emits different fields event/location/tiemstamp where as the messages.go definition has a bunch of other fields like TestCaseStartedId and TestStepId.

And the events in the generated file when using the "events" formatter aren't the ndjson style I was expecting but something else.

It's perhaps significant that the godog code doesn't acrually refer to the types in messages.go other than by string name, never by type.

Is the "event" formatter essentially unrelated to the "message" format?

Putting in the infra to make "message" work seems to touch much of the guts of godog - is that I wonder why this ticket is still open?

Thanks

(BTW long time no chat - came across some old google groups chats between us from back in 2010)

@Johnlon
Copy link
Member

Johnlon commented May 3, 2024

Likeky related to #617 as support for messages include support for attachments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚡ enhancement Request for new functionality
Projects
None yet
Development

No branches or pull requests

3 participants