Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: option to support full regular expressions #3

Open
thomasleplus opened this issue Sep 2, 2023 · 2 comments
Open

Comments

@thomasleplus
Copy link

thomasleplus commented Sep 2, 2023

Hi,

First of all, thank you for creating this plugin, it is very useful to me.

As I am big fan of regular expressions, I created a fork for myself to leave my search and replace inputs unescaped, this way I can use pattern matching in the search string and reference captured groups in the replace string:
thomasleplus@8e36b43

I am sure most users prefer literal search and replace but I was wondering if there is a way to have a configuration option in the plugin to give users the choice? This way I could use your plugin instead of maintaining my own fork.

I am not good enough at Typescript to create a PR for this and I don't even know if the Joplin plugin API supports some plugin configuration UI. But if you know and are interested in implementing this, I would appreciate it.

Thanks again,

Tom

@cuibonobo
Copy link
Owner

This is a great suggestion! I'll explore the possibility of adding a checkbox to the search & replace popup so that folks can choose one way or the other. I'll also explore how to add configuration options so that you can set whether your default is regex or not. It may take me a few weeks to get to this but I'll try to ship it in the next version.

@thomasleplus
Copy link
Author

Let me know if I can help testing or something.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants