Making list-remote a little more stable #33
Conversation
|
This is very very important to us, we get a lot of failed installation in our CI with no real fallback. |
fix local fallback
extracting more pages and versions
added more versions
make avners change work again
|
@avnerenv0 do you know if this is being reviewed? We are experiencing issues just like @omry-hay mentioned - CI is failing... |
env0 uses the fork, which we maintain and review. |
avnerenv0
changed the title
|
Ok, thank you. I will use the fork meanwhile - it works. |
|
Yeah this repo isn't really being maintained ... @cunymatthieu - would love to get your take on that - are you looking to add maintainers or transfer ownership ? |
fetching more version based on the amount of pages we can fetch
This reverts commit 5f213af.
remove set -e flag
Co-authored-by: sagilaufer1992 <[email protected]>
Fix delete version folder on curl fail
Replace cunymatthieu with env0 in README
…-in-custom-path Add: configure option to store version in custom-path
remove checking remote versions when installing
| @@ -28,8 +28,6 @@ else | |||
| fi | |||
|
|
|||
| [ -n "${version}" ] || error_and_die "Version is not specified" | |||
| version="$(tgenv-list-remote | grep -e "${regex}" | head -n 1)" | |||
| [ -n "${version}" ] || error_and_die "No versions matching '${1}' found in remote" | |||
There was a problem hiding this comment.
Hello,
I don't understand why you have removed the possibility to use the tag latest. Sometimes, you just want the latest version no matter what.
| return_code=$? | ||
| if [ $return_code -eq 22 ];then | ||
| warn_and_continue "Failed to get list verion on $link_release" | ||
| warn_and_continue "Failed to get list version on $link_release" | ||
| print=`cat ${TGENV_ROOT}/list_all_versions_offline` |
There was a problem hiding this comment.
Hello,
I don't see why the file list_all_version_offline is not in the .gitignore and updated each time the website is online
| return_code=$? | ||
| if [ $return_code -eq 22 ];then | ||
| warn_and_continue "Failed to get list verion on $link_release" | ||
| warn_and_continue "Failed to get list version on $link_release" | ||
| print=`cat ${TGENV_ROOT}/list_all_versions_offline` | ||
| fi | ||
|
|
There was a problem hiding this comment.
| echo $print | grep -o -E "[0-9]+\.[0-9]+\.[0-9]+(-(rc|beta)[0-9]+)?" | uniq | tee ${TGENV_ROOT}/list_all_versions_offline |
"Something is seriously wrong"
This reverts commit b3b7b89.
fix: Add retry for installation
Fix logs - make the visable in our app
closes #32