Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support higher pixel densities #4

Open
dfabulich opened this issue May 20, 2024 · 2 comments
Open

Support higher pixel densities #4

dfabulich opened this issue May 20, 2024 · 2 comments
Labels

Comments

@dfabulich
Copy link
Contributor

Apropos https://gitlab.com/DavidGriffith/frotz/-/issues/222

SDL Frotz doesn't yet support higher pixel densities, but hopefully some day it will, and, when it does, Infocom Frotz should do the same.

This was referenced May 20, 2024
@dfabulich
Copy link
Contributor Author

dfabulich commented Aug 15, 2024

In https://gitlab.com/DavidGriffith/frotz/-/issues/222 I figured out a workaround: Frotz accepts a settings file that sets the font size, width/height, and an "Infocom V6 Scaling" factor for images.

Unfortunately, the only way to set a font size is to provide your own TTF files and create a settings file referring to them. Then you can use the command-line -C parameter to load the config file, and then Frotz will load the TTF files.

I tried searching the code of this repository, and, I'll be honest, I have no idea how it works! I can see how I could pass TTF files and a settings file into preamble.mjs, but I can't see how frotz itself gets launched, or where I'd add command-line arguments.

If you can give me a hint as to how to pass a command-line argument, I'd be willing to try filing a PR to pass frotz a scaling factor.

@curiousdannii
Copy link
Owner

curiousdannii commented Aug 15, 2024

The CLI arguments is just the Module.arguments at the top of preamble.js. Frotz launches itself when the file is loaded.

Don't know if you noticed, but I had to add quite a few hacks to get better pixel densities on mobile, which are in the replaced functions in frotz-library.js. It will probably be hard to get further high-pixel stuff working, unless we just make it do a flat 2x or 3x for all browsers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants