refactor: reduce logic divergence

Author: AlbertoCentonze

contracts/Controller.vy

@@ -164,6 +164,11 @@ def __init__(
     borrowed_decimals: uint256 = convert(staticcall BORROWED_TOKEN.decimals(), uint256)
     BORROWED_PRECISION = pow_mod256(10, 18 - borrowed_decimals)
 
+    # This is useless for lending markets, but leaving it doesn't create any harm
+    assert extcall BORROWED_TOKEN.approve(
+        FACTORY.address, max_value(uint256), default_return_value=True
+    )
+
     self._monetary_policy = monetary_policy
     self.liquidation_discount = liquidation_discount
     self.loan_discount = loan_discount

contracts/MintController.vy

@@ -16,7 +16,8 @@ initializes: core
 
 # Usually a bad practice to expose through
 # `__interface__` but this contract is just
-# an adapter for the constructor of the Controller
+# an adapter to make the construct of Controller
+# compatible with the old mint factory.
 exports: core.__interface__
 
 
@@ -37,8 +38,3 @@ def __init__(
         amm,
         empty(address),  # to replace at deployment with view blueprint
     )
-
-    # TODO do this differently
-    assert extcall core.BORROWED_TOKEN.approve(
-        core.FACTORY.address, max_value(uint256), default_return_value=True
-    )

contracts/constants.vy

@@ -4,6 +4,5 @@ MIN_TICKS_UINT: constant(uint256) = 4
 MAX_TICKS: constant(int256) = 50
 
 DEAD_SHARES: constant(uint256) = 1000
-# TODO make sure this is used everywhere
 WAD: constant(uint256) = 10**18
 SWAD: constant(int256) = 10**18