Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

matcher needs image as an input #42

Open
YJonmo opened this issue Aug 3, 2023 · 3 comments
Open

matcher needs image as an input #42

YJonmo opened this issue Aug 3, 2023 · 3 comments

Comments

@YJonmo
Copy link

YJonmo commented Aug 3, 2023

Hi there,

Thanks for this great work.

In class LightGlue(nn.Module), the images are not mentioned as required_data_keys. But later on they are needed in the forward function:
kpts0 = normalize_keypoints(
kpts0_, size=data.get('image_size0'), shape=data['image0'].shape)
kpts1 = normalize_keypoints(
kpts1_, size=data.get('image_size1'), shape=data['image1'].shape)

@Phil26AT
Copy link
Collaborator

Phil26AT commented Aug 3, 2023

Hey @YJonmo

Thanks for opening your issue! This was indeed a bug in the initial code, and has since been fixed in PR #22. Furthermore, in the newest PR #37, we perform normalization based on the available keypoints, so it is not required to forward image_size or image to the matcher anymore.

I suggest pulling the latest changes where this issue should be fixed.

@ducha-aiki
Copy link
Contributor

@YJonmo or you can use matching interface from the kornia: https://kornia.readthedocs.io/en/latest/feature.html#kornia.feature.LightGlueMatcher

@YJonmo
Copy link
Author

YJonmo commented Nov 10, 2023

Hi there,

Sorry for reopening this query.

I tried to use kornia as you suggested but have an issue with it.

Have you tried to get the LighGlue in kornia running?

Cheers,
Yaqub

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants