Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate 'whitelist' and replace with 'allowed_users` #21

Open
ianhinder opened this issue Mar 17, 2023 · 1 comment
Open

Deprecate 'whitelist' and replace with 'allowed_users` #21

ianhinder opened this issue Mar 17, 2023 · 1 comment

Comments

@ianhinder
Copy link

If I follow the example in the README, and set

c.CASLocalAuthenticator.whitelist = {'foo'}

I get a warning

jupyterhub-jupyterhub-1  | [W 2023-03-17 16:34:31.450 JupyterHub auth:175] CASLocalAuthenticator.whitelist is deprecated in JupyterHub 1.2, use CASLocalAuthenticator.allowed_users instead

However, if I replace whitelist with allowed_users, while the error message goes away, the server is now open to any user, since jhub_cas_authenticator is only checking the "whitelist" variable.

I propose that the check against whitelist is replace with a check against either variable.

@cwaldbieser
Copy link
Owner

I just pushed a change to master. Can you test if that works how you expect? It's a small change and I am pretty confident it should work. Even so, I'd like a test before I cut a release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants