Searching for filtering available files on the load dialog seems broken

[SusanBrown]

Search seems totally to be broken

Expected Behaviour

If I enter the name of a file in part I expect the list to be filtered to show only the available files that have strings matching my search string.

Current Behaviour

There are no matches when there should be:

[ilovan]

Great catch, @SusanBrown .
@ajmacdonald , dev-cwr-writer is returning an even weirder result:

[ajmacdonald]

@SusanBrown the search is performed on the text of the files within the repos not the names of the repos themselves

[SusanBrown]

Could it search names of files, names of repos, and text content? On Aug 9, 2019, 2:25 PM -0400, Andrew <[email protected]>, wrote: @SusanBrown<https://github.com/SusanBrown> the search is performed on the text of the files within the repos not the names of the repos themselves — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#32?email_source=notifications&email_token=AAEFJIEMPV3EEOQDLWAX5DLQDWY7PA5CNFSM4IKPMTYKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD37NRXQ#issuecomment-520018142>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AAEFJIB5HIMACR7R67IGGNDQDWY7PANCNFSM4IKPMTYA>.

[ajmacdonald]

@ilovan I've fixed the issue on dev

[ajmacdonald]

@SusanBrown yes that's possible but not straightforward since those are two different calls

[ajmacdonald]

Searching file names within repos will be tricky. Whereas there's a method in the GitHub API for searching within file contents, there is no equivalent for file names.

You can see this reflected in the interface on GitHub itself.
Searching within a repository does not include file name matches: https://github.com/cwrc/cwrc-git-dialogs/search?q=load&unscoped_q=load
You must instead use a separate page to search by file name: https://github.com/cwrc/cwrc-git-dialogs/find/master

A workaround would require fetching the contents of each repo for a user, then searching within those contents. Depending on the number of repos a user owns, this could be a very expensive operation. A compromise might be to have the user select a repo first, then have the ability to search within that particular repo.

[SusanBrown]

What you suggest sounds like a very good approach to me. On Nov 15, 2019, at 3:02 PM, Andrew <[email protected]<mailto:[email protected]>> wrote: Searching file names within repos will be tricky. Whereas there's a method in the GitHub API for searching within file contents<https://developer.github.com/v3/search/#search-code>, there is no equivalent for file names. You can see this reflected in the interface on GitHub itself. Searching within a repository does not include file name matches: https://github.com/cwrc/cwrc-git-dialogs/search?q=load&unscoped_q=load You must instead use a separate page to search by file name: https://github.com/cwrc/cwrc-git-dialogs/find/master A workaround would require fetching the contents of each repo for a user, then searching within those contents. Depending on the number of repos a user owns, this could be a very expensive operation. A compromise might be to have the user select a repo first, then have the ability to search within that particular repo. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#32?email_source=notifications&email_token=AAEFJIFRQEEZWHFVUPGN6MLQT356LA5CNFSM4IKPMTYKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEEGR3HQ#issuecomment-554507678>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAEFJICT6WBRKDO6MSGWDHDQT356LANCNFSM4IKPMTYA>.

[ajmacdonald]

Great! @SusanBrown
I think we might then also want to consider switching to a multi-column layout for the load/browse dialog, similar to the Mac OS Finder.
Column 1: repo search
Column 2: repo search results
Column 3: selected repo contents, including an input for searching within the repo

[SusanBrown]

Sounds good. I always stumble on that particular finder view actually and end up switching away from it ;) but if this is the logical way to go, let’s go for it. Do you need help from Mihaela by way of a mockup or anything? On Nov 15, 2019, at 3:30 PM, Andrew <[email protected]<mailto:[email protected]>> wrote: Great! @SusanBrown<https://github.com/SusanBrown> I think we might then also want to consider switching to a multi-column layout for the load/browse dialog, similar to the Mac OS Finder. Column 1: repo search Column 2: repo search results Column 3: selected repo contents, including an input for searching within the repo — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#32?email_source=notifications&email_token=AAEFJIGH6CF4WCVLWP3HLCTQT4BFZA5CNFSM4IKPMTYKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEEGUCHQ#issuecomment-554516766>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAEFJIDEURBGJHCM2Q2ZSALQT4BFZANCNFSM4IKPMTYA>.

[ajmacdonald]

e6dd57a

[ilovan]

working now on dev-cwrc-writer