From b279314fa5194fc1db0f4b8094efee855d90e862 Mon Sep 17 00:00:00 2001
From: Esen Dzhailobaev <s7b5en@gmail.com>
Date: Sun, 24 Nov 2024 05:50:30 +0600
Subject: [PATCH] Check for gesture zone in `TraceGesture` too (#2617)

---
 src/components/MultiGesture.tsx | 11 +++--------
 src/components/TraceGesture.tsx |  9 +++++++--
 src/util/isInGestureZone.ts     | 14 ++++++++++++++
 3 files changed, 24 insertions(+), 10 deletions(-)
 create mode 100644 src/util/isInGestureZone.ts

diff --git a/src/components/MultiGesture.tsx b/src/components/MultiGesture.tsx
index b8c0b52df3..10b3c17c99 100644
--- a/src/components/MultiGesture.tsx
+++ b/src/components/MultiGesture.tsx
@@ -4,7 +4,7 @@ import Direction from '../@types/Direction'
 import GesturePath from '../@types/GesturePath'
 import { noop } from '../constants'
 import gestureStore from '../stores/gesture'
-import viewportStore from '../stores/viewport'
+import isInGestureZone from '../util/isInGestureZone'
 import ScrollZone from './ScrollZone'
 import TraceGesture from './TraceGesture'
 
@@ -51,8 +51,6 @@ type MultiGestureProps = PropsWithChildren<{
   shouldCancelGesture?: () => boolean
 }>
 
-const TOOLBAR_HEIGHT = 50
-
 /** Static mapping of intercardinal directions to radians. Used to determine the closest gesture to an angle. Range: -π to π. */
 const dirToRad = {
   NW: -Math.PI * (3 / 4),
@@ -125,15 +123,12 @@ class MultiGesture extends React.Component<MultiGestureProps> {
         const x = e.touches[0].clientX
         const y = e.touches[0].clientY
         this.clientStart = { x, y }
+        const inGestureZone = isInGestureZone(x, y, this.leftHanded)
 
         // disable gestures in the scroll zone on the right side of the screen
         // disable scroll in the gesture zone on the left side of the screen
         // (reverse in left-handed mode)
-        const viewport = viewportStore.getState()
-        const scrollZoneWidth = viewport.scrollZoneWidth
-        const isInGestureZone =
-          (this.leftHanded ? x > scrollZoneWidth : x < viewport.innerWidth - scrollZoneWidth) && y > TOOLBAR_HEIGHT
-        if (isInGestureZone && !props.shouldCancelGesture?.()) {
+        if (inGestureZone && !props.shouldCancelGesture?.()) {
           this.disableScroll = true
         } else {
           this.abandon = true
diff --git a/src/components/TraceGesture.tsx b/src/components/TraceGesture.tsx
index f5ebeed69a..3afea73d83 100644
--- a/src/components/TraceGesture.tsx
+++ b/src/components/TraceGesture.tsx
@@ -8,6 +8,7 @@ import themeColors from '../selectors/themeColors'
 import { gestureString, globalShortcuts } from '../shortcuts'
 import gestureStore from '../stores/gesture'
 import viewportStore from '../stores/viewport'
+import isInGestureZone from '../util/isInGestureZone'
 import FadeTransition from './FadeTransition'
 
 interface TraceGestureProps {
@@ -36,6 +37,7 @@ const useConditionDelay = (condition: boolean, milliseconds: number) => {
 /** Draws a gesture as it is being performed onto a canvas. */
 const TraceGesture = ({ eventNodeRef }: TraceGestureProps) => {
   const colors = useSelector(themeColors)
+  const leftHanded = useSelector(getUserSetting(Settings.leftHanded))
 
   // A hook that is true when there is a cancelled gesture in progress.
   // Handles GestureHint and CommandPaletteGesture which have different ways of showing a cancelled gesture.
@@ -92,7 +94,10 @@ const TraceGesture = ({ eventNodeRef }: TraceGestureProps) => {
       // Make preventDefault a noop otherwise tap-to-edit is broken.
       // e.cancelable is readonly and monkeypatching preventDefault is easier than copying e.
       e.preventDefault = noop
-      handlePointerStart(e)
+      const shouldActivateGesture = isInGestureZone(e.clientX, e.clientY, leftHanded)
+      if (shouldActivateGesture) {
+        handlePointerStart(e)
+      }
     })
     eventNode?.addEventListener('pointermove', e => {
       e.preventDefault = noop
@@ -111,7 +116,7 @@ const TraceGesture = ({ eventNodeRef }: TraceGestureProps) => {
       eventNode?.removeEventListener('pointermove', handlePointerMove)
       signaturePad.removeEventListener('beginStroke', onBeginStroke)
     }
-  }, [eventNodeRef, onBeginStroke])
+  }, [eventNodeRef, onBeginStroke, leftHanded])
 
   return (
     <div
diff --git a/src/util/isInGestureZone.ts b/src/util/isInGestureZone.ts
new file mode 100644
index 0000000000..f942203f6c
--- /dev/null
+++ b/src/util/isInGestureZone.ts
@@ -0,0 +1,14 @@
+import viewportStore from '../stores/viewport'
+
+const TOOLBAR_HEIGHT = 50
+
+/** Returns true if the pointer is in the gesture zone. To the right for righties, to the left for lefties. */
+const isInGestureZone = (x: number, y: number, leftHanded: boolean) => {
+  const viewport = viewportStore.getState()
+  const scrollZoneWidth = viewport.scrollZoneWidth
+  const isInGestureZone =
+    (leftHanded ? x > scrollZoneWidth : x < viewport.innerWidth - scrollZoneWidth) && y > TOOLBAR_HEIGHT
+  return isInGestureZone
+}
+
+export default isInGestureZone