Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade/patch/replace Go build image #103

Open
4 tasks
erikgb opened this issue Oct 26, 2023 · 3 comments
Open
4 tasks

Upgrade/patch/replace Go build image #103

erikgb opened this issue Oct 26, 2023 · 3 comments

Comments

@erikgb
Copy link
Contributor

erikgb commented Oct 26, 2023

What

The image used to build the operator binary seems to be a Cybozu Ubuntu Jammy based image:

FROM quay.io/cybozu/golang:1.20-jammy as builder

Is there any particular reason for not using the official Go image, https://hub.docker.com/_/golang?

How

Replace the Go binary build image with golang:1.21, eventually an exact image digest if we want reproducible builds.

Checklist

  • Finish implementation of the issue
  • Test all functions
  • Have enough logs to trace activities
  • Notify developers of necessary actions
@zoetrope
Copy link
Member

zoetrope commented Nov 1, 2023

I've upgraded to go1.21 for now. #105

While I'm using quay.io/cybozu/golang in accordance with our company policy, I believe we could also use the official golang if needed.

@erikgb
Copy link
Contributor Author

erikgb commented Nov 1, 2023

While I'm using quay.io/cybozu/golang in accordance with our company policy, I believe we could also use the official golang if needed.

We would prefer a more open/neutral base image. Is the current base image open-sourced?

@yamatcha
Copy link
Contributor

Base image is built in this open-source repository.
https://github.com/cybozu/neco-containers/tree/main/golang-all

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants