manual trigger: future hold list ignored

[hjoliver]

Future tasks can be held - they're recorded in a "hold list" so that once spawned into the active pool they will be held.
This works as advertised for natural triggering, but not for manual triggering.

Current behaviour for manually triggering held tasks:

1. existing held tasks (e.g. waiting with partially satisfied prerequisites):
   • tasks run, but retain the held attribute (to prevent subsequent job submissions)
2. future held task:
   • tasks run without having the held attribute applied

I think 1. is correct behaviour, and 2. is a bug - it should run as held (same as 1.)

ASIDE: I suppose we could decree that held tasks will not trigger naturally or manually, but I think it's more reasonable to have them run (I would not do a manual trigger if I didn't want it to run) but retain the held attribute to prevent subsequent job submission.

[oliver-sanders]

I think 1. is correct behaviour, and 2. is a bug - it should run as held (same as 1.)

Agreed (remove question label if happy with this).

I suppose we could decree that held tasks will not trigger naturally or manually, but I think it's more reasonable to have them run

Manual trigger should always override the held state.