Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrated the updated fonts solution from https://github.com/cynkra/cy… #2199

Closed
wants to merge 1 commit into from

Conversation

talpitoo
Copy link
Collaborator

…nkraweb/issues/662

NOTE: related to https://github.com/cynkra/cynkraweb/issues/662

Copy link
Contributor

aviator-app bot commented Feb 29, 2024

Current Aviator status

Aviator will automatically update this comment as the status of the PR changes.
Comment /aviator refresh to force Aviator to re-examine your PR (or learn about other /aviator commands).

This PR was closed without merging. If you still want to merge this PR, re-open it.


See the real-time status of this PR on the Aviator webapp.
Use the Aviator Chrome Extension to see the status of your PR within GitHub.

@talpitoo
Copy link
Collaborator Author

@christophsax @maelle please see my other comment here cynkra/cynkratemplate#52 (comment)

@maelle
Copy link
Member

maelle commented Mar 4, 2024

So, building this locally I can't see the text on the cheatsheet. Did the links to the files change in the meantime?

image

Steps

  • install.packages("pkgdown")
  • install.packages("pak")
  • install.packages("servr")
  • pak::pak()
  • devtools::install()
  • pkgdown::build_site()
  • servr::httw("docs")

@talpitoo
Copy link
Collaborator Author

talpitoo commented Mar 4, 2024

@maelle i don't know where those links are coming from. This PR contains only 3 .woff2 URLs, e.g. https://cynkra.com/assets/css/fonts/1449009/b3ca2df2-7bee-4fc0-84cb-b029b99c3b61.woff2 but your screenshot points to S3. I am not aware of the deeper architecture or cross-referencing other repos, e.g. cynkratemplate if plays a role or not. Maybe it will be okay on production and the S3 URLs appear on local builds only? cc. @christophsax

@krlmlr
Copy link
Collaborator

krlmlr commented Aug 14, 2024

Maëlle, can you please work with @talpitoo to resolve this?

@maelle maelle force-pushed the feat/fonts-refactoring-frutiger branch from 3efd0f7 to 77017eb Compare September 17, 2024 08:56
@maelle
Copy link
Member

maelle commented Sep 17, 2024

Currently building the pkgdown website locally.

@maelle
Copy link
Member

maelle commented Sep 17, 2024

still getting this

image

@krlmlr
Copy link
Collaborator

krlmlr commented Sep 17, 2024

docs-* branch?

@maelle
Copy link
Member

maelle commented Sep 17, 2024

I contacted devops via mattermost

@maelle
Copy link
Member

maelle commented Sep 17, 2024

will open a new pr with a docs- branch

@maelle
Copy link
Member

maelle commented Sep 17, 2024

#2233

@maelle maelle closed this Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants