diff --git a/R/parse-news-items.R b/R/parse-news-items.R index 1bcd666f..10fdc56c 100644 --- a/R/parse-news-items.R +++ b/R/parse-news-items.R @@ -375,7 +375,9 @@ harvest_pr_data <- function(message) { ) tibble::tibble( - title = pr_info$title %||% NA_character_, + # FIXME: Better default message without PR info + # if the message is already in Conventional Commit format + title = pr_info$title %||% paste0("- ", message), pr_number = pr_number, issue_numbers = list(issue_numbers), external_ctb = external_ctb, diff --git a/tests/testthat/_snaps/parse-news-items.md b/tests/testthat/_snaps/parse-news-items.md index dd8d6f9f..35ab53db 100644 --- a/tests/testthat/_snaps/parse-news-items.md +++ b/tests/testthat/_snaps/parse-news-items.md @@ -76,7 +76,7 @@ # A tibble: 1 x 4 description type breaking scope - 1 PLACEHOLDER https://github.com/cynkra/fledge/pull/332 (#~ Unca~ FALSE NA + 1 Merge pull request #332 from cynkra/conventional-parsing~ Unca~ FALSE NA # Can parse PR merge commits - PAT absence @@ -92,7 +92,7 @@ [ { - "title": "NA", + "title": "- Merge pull request #332 from cynkra/conventional-parsing", "pr_number": "332", "issue_numbers": "", "external_ctb": "NA"