-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
experiment with less resource wasting #161
Conversation
Ah I think it now really works (the regex in the pkgdown workflow was catching this branch 😅 ) |
@krlmlr I'm hoping it'd also work for forks. |
Can we deploy automatically, but only if the documentation changes? We're still running a huge build matrix... |
Do you mean pre-pkgdown building or do you mean post-pkgdown building? It's unclear to me where we'd store information on what the last deploy website and source were. 🤔 With this change we'd manually decide whether to label the PR as needs-preview so I assume less often than at each commit. |
We'd assume that Let's put this on the backburner for now. |
The biggest waste is running the big check matrix, I'm mitigating this by only doing this for contributed PRs. Might consider switching to weekly checks (instead of daily) for all packages too. |
Current Aviator status
This PR was closed without merging. If you still want to merge this PR, re-open it.
See the real-time status of this PR on the
Aviator webapp.
Use the Aviator Chrome Extension
to see the status of your PR within GitHub.
|
Fix #135
@krlmlr I have been thinking about wasting resources cf https://www.ryanfiller.com/blog/why-my-blog-stopped-using-deploy-previews
With this workflow, to get a preview one adds the "needs-preview" label. I'd like to merge this to then try again as currently I think the PR workflow from master applies? I see the label workflow works but I am not sure it posts the URL as commit status.