From 0e2a90a3a6396cd533c0781b929f0f38b1c8ec72 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Kirill=20M=C3=BCller?= Date: Mon, 6 Nov 2023 06:07:30 +0100 Subject: [PATCH] feat: Do not report installation size problems --- R/auto.R | 15 +++++++++++++-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/R/auto.R b/R/auto.R index 2e4f52b8e..4cd653b88 100644 --- a/R/auto.R +++ b/R/auto.R @@ -335,8 +335,19 @@ get_cransplainer_update <- function(package) { details <- foghorn::cran_details(package) details <- details[details$result != "OK", ] + + # We know that installation size warnings are fine + is_size_problem <- grepl("installed size", details$message) + details <- details[!is_size_problem, ] + if (nrow(details) == 0) { - return(paste0("- [x] ", checked_on, ", no problems found.")) + return(paste0( + "- [x] ", + checked_on, + ", no problems ", + if (any(is_size_problem)) "(other than installation size) ", + "found." + )) } url <- foghorn::visit_cran_check(package) @@ -344,7 +355,7 @@ get_cransplainer_update <- function(package) { cransplainer <- paste0( "- [x] ", checked_on, ", problems found: ", url, "\n", - paste0("- [ ] ", details$result, ": ", details$flavors, collapse = "\n") + paste0("- [ ] ", details$result, ": ", details$flavors, "\n", details$message, collapse = "\n") ) paste0(cransplainer, "\n\nCheck results at: ", url)