JSON fixtures with unicode escape sequences are not parsed correctly

[vschoettke]

See the "Current behavior" for bug details.

I already boiled the problem down to an error in the jsonlint module that is used for parsing the JSON data in

cypress/packages/server/lib/fixture.coffee

Line 90 in a888f89

.then(jsonlint.parse)

and filed and issue there (zaach/jsonlint#102), but because that last commit is 3 years ago I don't know if it's still maintained.

Returning the result of JSON.parse() if no jsonlint error happened will fix the error while still keeping jsonlint as validator.

• Operating System: MacOS 10.13.1
• Cypress Version: 1.1.2
• Browser Version: not relevant

Is this a Feature or Bug?

This is a bug.

Current behavior:

A JSON file that contains unicode escape sequences (\uXXXX) in string values is not parsed correctly ("\uXXXX" results in "\uXXXX").

Desired behavior:

JSON fixture is parsed correctly.

How to reproduce:

See https://github.com/vschoettke/cypress_fixture_parse_bug for an example

Test code:

fixtures/test_error.json

{
    "name": "\u30d0\u30b0"
}

integration/test_spec.js

describe("cypress should load json fixture with unicode specifier correctly", () => {
    it("should decode correctly", () => {
        cy.server();
        cy.fixture("test_error.json").then((data) => {
            const realData = require("../fixtures/test_error.json");
            expect(data.name).to.equal(realData.name);
        });
    });
});

[bahmutov]

Might switch to updated fork https://github.com/circlecell/jsonlint-mod or just use JSON.parse

[bahmutov]

Yeah, seems it is escaping the slash, so it does not process unicode JSON fixtures correctly.

[brian-mann]

Released in 1.1.3.