-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Large graphs: Faster graph object creation #275
Comments
Thanks for opening the issue!
This makes sense to me, it seems like it'd work... I'm just worried with the synchronization problems that @MridulS implemented most of these methods :) You have an opinion on this? |
This should be possible but I think this will take up some initial effort to implement the |
Yes, that would be terrible. But (I just look at the code)...
Theoretically, the interactivity should be preserved because edges is a |
Problem
The slowest part for me is the edge creation. The
Edge()
constructor is called n-edge times at cytoscape.py#L524. It's not theEdge
constructor that's slow, but theWidget
constructor from whichEdge
inherits.Proposed Solution
I already started a SO question asking about the most efficient way to create a large number of
Widget
objects here.It seems to me that the solution would require a new
EdgeList
class that internally handles a list of edges and just needs a singleWidget
constructor call, but I don't know the internals, so this might as well be non-sense.Btw, the same applies to the
Node
constructor, but it's a smaller problem for me ATMThe text was updated successfully, but these errors were encountered: