-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make another PULL REQUEST to update d-cent/democracyos/.../custom.css #56
Comments
D-CENT logo has been uploaded in colour and in gray here: https://github.com/d-cent/patterns/tree/master/source/assets/img I will change the language file next week, once urgent tasks have been finished today and tomorrow. |
@jaakkokorhonen: @saariokari and I just had our call and we sorted out the approach for addressing al these. He had some doubts about some specific stuff he'll be discussing with you. Regarding the issue descriptions and questions for me:
This is just adding custom CSS for the desired elements; it shouldn't be a big deal.
The activity stream widget is designed to display data in the ActivityStream 2.0 format, so basically any data in that format should be displayable. Of course, for the sample implementation we're showing a simple sample that can be updated for any specific need (current sample hard-coded data can be seen here). As to where that data comes from, it depends entirely on a pilot's needs; I believe decisions API was the case for the Finnish pilot. User 'activity log' isn't stored by the app itself so I don't know how it's supposed to show user activity without having a record of that created. Again, that's dependent on each pilot (for instance, Guanyem had no need or use for this).
We tried this approach but it was causing a bit of problems on the frontend layout so we decided to go for an 'edit' button to enable profile editing. What can be done for a UI flow similar to what you propose, is making the same 'button' functionality for all profile elements insted (i.e.: clicking on the user name would open up the edit mode on the name input, etc.). The rest of the items were addressed on our call and @saariokari felt confident about being able to address them. |
Created a pull request. |
@gvilarino The coloured logo on the top left corner needs to be replaced with a white one, here: https://github.com/d-cent/patterns/tree/master/public/assets/img Seems there was a mis-communication: Top corner should be white: https://github.com/d-cent/patterns/blob/master/source/assets/img/D-CENT_white.svg bottom should colored: https://github.com/d-cent/patterns/blob/master/public/assets/img/D-CENT_Logo.png) |
@jayapapaya that's something @saariokari should be handling this since it concerns his PR; I will handle any PR's but I'm not doing UI work. |
Ok, sure thing. Not sure how you guys have divied up the work between you. @saariokari ? Any chance you can add this to the top left: https://github.com/d-cent/patterns/blob/master/source/assets/img/D-CENT_white.svg and this to the bottom left: https://github.com/d-cent/patterns/blob/master/source/assets/img/D-CENT_logo.svg |
UI-wise, I'm only merging PRs |
@jaakkokorhonen edited the language file: https://github.com/d-cent/democracyos/blob/development/lib/translations/lib/en.json The DCENT in the top left of the nav bar needs to be D-CENT though - and is not in the language file. And there is also the D-CENT spelling issue is the herokuapp domain name - don't know if this is something we can easily correct. |
I'll change the logos. |
Created a pull request with sidebar bottom logo and added white logo to heroku config. |
Nice one, thanks @saariokari |
@saariokari the request to have full logo at top looks pretty bad :(
last change on this, promise! |
Is it possible to update the logos on the Finnish instance (http://finnish-democracyos.herokuapp.com/) also? Would be nice for tomorrow's kickoff with pilot users, if trivial. |
@joonasp it's already updated with the latest changes. |
Logo in http://democracyos-dcent.herokuapp.com/ top left corner needs to be changed to: https://github.com/d-cent/patterns/blob/master/source/assets/img/D_forD-CENT_white.png @jaakkokorhonen? @saariokari? Final logo change for the EC review, promise. |
I'll add this today. |
I changed the logo in the heroku config and also noticed that there are some errors on the site. I think my logo change did not cause those? @gvilarino |
I merged and pushed your pull requests, all other changes I made were related either to localization issues or release/publish stuff. What changes/errors are you referring to? btw, @saariokari you can check the commit history; your commits there are intact. |
@saariokari errors on the site are related to inconsistent data as per this discussion |
Add D-CENT "(d-)cent" logo on left top with “Home” next to it (link to home)
Pull “Powered by Democracy OS and D-CENT” with logos on the left, bottom (see http://codietic.herokuapp.com/) to Patterns.
Add “Powered by Democracy OS and D-CENT” with logos on the left, bottom (see http://codietic.herokuapp.com/).
Apply styles in http://d-cent.github.io/patterns/public/?p=viewall-molecules-messaging for message to users about what is happening (eg. “No votes cast”)
@gvilarino please propose a technical solution for this.
Apply tags/ keyword styles in http://d-cent.github.io/patterns/public/?p=atoms-tags
Activity stream should record users activities (M3). If there is no data it should be hidden. @gvilarino is there going to be data in the Activity Stream?
@gvilarino is it Possible to have in-place editing of profile on the same page instead of an extra click away?
Update voting button colours and text to Patterns:
“Yea” to “Yes” - button border/text #00B259 and button background #BFFFDF
“Nay” to “No” - button border/text #FF4000 and button background #FFBFBF
“Abstain” - button border/text #666666 and button background #EEEEEE
Update voting button colours to custom.css.
@jayapapaya can you change the language text in https://github.com/d-cent/democracyos/tree/development/lib/translations/lib. There is probably more than just vote buttons to change. You can also change spelling of D-CENT. (D-CENT in text and d-cent for URLs).
Blue in the dropdown of “Order by: Relevance” change to #007E84
Blue in the left hand menu of the admin panel change to #007E84
The text was updated successfully, but these errors were encountered: