Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows compatibility issues on file encoding and shell commands #42

Open
garylavayou opened this issue Jan 12, 2022 · 1 comment
Open

Comments

@garylavayou
Copy link

Multiple modules including sphinx.py, config.py, and build.py do not explicitly set the encoding='utf-8' option for Python open() function. As a result, the default encoding is gbk on Windows, but the file encoding is utf-8, thus resulting in

UnicodeDecodeError: 'gbk' codec can't decode byte 0x80 in position 884

In addition, the build script uses Linux shell commands such as, rm, cp, etc.
As there are no equivalent commands in Windows shell, the script cannot be run on Windows.

Future updates might address the aforementioned issues in order to support d2lbook to run on Windows.

@garylavayou garylavayou changed the title Windows platform compatibility issues on file encoding and shell commands Windows compatibility issues on file encoding and shell commands Jan 12, 2022
@AnirudhDagar
Copy link
Member

@garylavayou we most probably have no plans to support windows in the near future. Feel free to send a PR if you'd like to add that or edit your own fork if that works for you. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants