Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define what expressions can be put in a colour declaration #50

Open
falkecarlsen opened this issue Mar 26, 2019 · 2 comments
Open

Define what expressions can be put in a colour declaration #50

falkecarlsen opened this issue Mar 26, 2019 · 2 comments

Comments

@falkecarlsen
Copy link
Member

Currently only integer_literals are allowed in a state colour declaration. Adding support for expressions, and more importantly, restricting these needs to be done.

@jenrik
Copy link
Member

jenrik commented Apr 11, 2019

I think it would be best if we limited expressions in the colors to things that can be computed at compile time. Loop and functions should probably be forbidden since we can't always determine if they will terminate. Functions could enter an infinite loop through recursion.

We could check for the presence of certain nodes in the color expression by running a custom sanity checking visitor on the color expression subtree.

@jenrik
Copy link
Member

jenrik commented Apr 11, 2019

#30 discusses the same issue, and has suggestions on what should be allowed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants