Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace guava's com.google.common.io.Files implementation with analog from jdk7 #3808

Open
kofemann opened this issue Feb 11, 2018 · 1 comment · May be fixed by #7278
Open

Replace guava's com.google.common.io.Files implementation with analog from jdk7 #3808

kofemann opened this issue Feb 11, 2018 · 1 comment · May be fixed by #7278
Labels
easypick education

Comments

@kofemann
Copy link
Member

dCache code base heavily uses Googl's guava library. However, newer JDK releases providing similar functionality. For instance, com.google.common.io.Files can be replaced with java.nio.file.Files to reduce dependency on external library.
@jobegrabber
Copy link
Contributor

Will do

jobegrabber added a commit to jobegrabber/dcache that referenced this issue Feb 14, 2019
@jobegrabber
various: replace guava Files usages JDK Files
9282d04 
Motivation:

From dCache#3808: The dCache heavily utilizes Google's guava library. For some
use cases the JDK standard library now offers similar functionality.
Here a few  com.google.common.io.Files can be replaced with java.nio.file.Files
invocations.

Modification:

Reduce dependency on external library guava by utilizing
java.nio.file.Files' methods instead of the ones provided by
com.google.common.io.Files (where applicable).

Result:

Keeping behaviour the same while having reduced dependency on guava.

Target: master
Signed-off-by: Jonas Grabber <[email protected]>
jobegrabber added a commit to jobegrabber/dcache that referenced this issue Feb 14, 2019
@jobegrabber
various: replace guava Files usages JDK Files
3f63ce0 
Motivation:

From dCache#3808: The dCache heavily utilizes Google's guava library. For some
use cases the JDK standard library now offers similar functionality.
Here a few  com.google.common.io.Files can be replaced with java.nio.file.Files
invocations.

Modification:

Reduce dependency on external library guava by utilizing
java.nio.file.Files' methods instead of the ones provided by
com.google.common.io.Files (where applicable).

Result:

Keeping behaviour the same while having reduced dependency on guava.

Target: master
Signed-off-by: Jonas Grabber <[email protected]>
jobegrabber added a commit to jobegrabber/dcache that referenced this issue Feb 14, 2019
@jobegrabber
various: replace guava Files usages JDK Files
9169408 
Motivation:

From dCache#3808: The dCache library heavily utilizes Google's guava library. For some
use cases the JDK standard library now offers similar functionality.
Here a few  com.google.common.io.Files can be replaced with java.nio.file.Files
invocations.

Modification:

Reduce dependency on external library guava by utilizing
java.nio.file.Files' methods instead of the ones provided by
com.google.common.io.Files (where applicable).

Result:

Keeping behaviour the same while having reduced dependency on guava.

Target: master
Signed-off-by: Jonas Grabber <[email protected]>
jobegrabber added a commit to jobegrabber/dcache that referenced this issue Feb 14, 2019
@jobegrabber
various: replace guava Files usages with JDK Files
88cdcbb 
Motivation:

From dCache#3808: The dCache library heavily utilizes Google's guava library. For some
use cases the JDK standard library now offers similar functionality.
Here a few  com.google.common.io.Files can be replaced with java.nio.file.Files
invocations.

Modification:

Reduce dependency on external library guava by utilizing
java.nio.file.Files' methods instead of the ones provided by
com.google.common.io.Files (where applicable).

Result:

Keeping behaviour the same while having reduced dependency on guava.

Target: master
Signed-off-by: Jonas Grabber <[email protected]>
jobegrabber added a commit to jobegrabber/dcache that referenced this issue Feb 14, 2019
@jobegrabber
various: replace guava Files usages with JDK Files
5ee26ec 
Motivation:

From dCache#3808: The dCache library heavily utilizes Google's guava library. For some
use cases the JDK standard library now offers similar functionality.
Here a few  com.google.common.io.Files can be replaced with java.nio.file.Files
invocations.

Modification:

Reduce dependency on external library guava by utilizing
java.nio.file.Files' methods instead of the ones provided by
com.google.common.io.Files (where applicable).

Result:

Keeping behaviour the same while having reduced dependency on guava.

Target: master
Signed-off-by: Jonas Grabber <[email protected]>
jobegrabber added a commit to jobegrabber/dcache that referenced this issue Feb 14, 2019
@jobegrabber
various: replace guava Files usages with JDK Files
b6174da 
Motivation:

From dCache#3808: The dCache library heavily utilizes Google's guava library. For some
use cases the JDK standard library now offers similar functionality.
Here a few  com.google.common.io.Files can be replaced with java.nio.file.Files
invocations.

Modification:

Reduce dependency on external library guava by utilizing
java.nio.file.Files' methods instead of the ones provided by
com.google.common.io.Files (where applicable).

Result:

Keeping behaviour the same while having reduced dependency on guava.

Fixes: dCache#3808
Target: master
Require-book: no
Require-notes: no
Signed-off-by: Jonas Grabber <[email protected]>
jobegrabber added a commit to jobegrabber/dcache that referenced this issue Feb 16, 2019
@jobegrabber
various: replace guava Files usages JDK Files
1ec7f85 
Motivation:

From dCache#3808: The dCache heavily utilizes Google's guava library. For some
use cases the JDK standard library now offers similar functionality.
Here a few  com.google.common.io.Files can be replaced with java.nio.file.Files
invocations.

Modification:

Reduce dependency on external library guava by utilizing
java.nio.file.Files' methods instead of the ones provided by
com.google.common.io.Files (where applicable).

Result:

Keeping behaviour the same while having reduced dependency on guava.

Target: master
Signed-off-by: Jonas Grabber <[email protected]>
jobegrabber added a commit to jobegrabber/dcache that referenced this issue Feb 16, 2019
@jobegrabber
various: replace guava Files usages JDK Files
dff3072 
Motivation:

From dCache#3808: The dCache heavily utilizes Google's guava library. For some
use cases the JDK standard library now offers similar functionality.
Here a few  com.google.common.io.Files can be replaced with java.nio.file.Files
invocations.

Modification:

Reduce dependency on external library guava by utilizing
java.nio.file.Files' methods instead of the ones provided by
com.google.common.io.Files (where applicable).

Result:

Keeping behaviour the same while having reduced dependency on guava.

Target: master
Signed-off-by: Jonas Grabber <[email protected]>
jobegrabber added a commit to jobegrabber/dcache that referenced this issue Feb 16, 2019
@jobegrabber
various: replace guava Files usages JDK Files
3de5f34 
Motivation:

From dCache#3808: The dCache heavily utilizes Google's guava library. For some
use cases the JDK standard library now offers similar functionality.
Here a few  com.google.common.io.Files can be replaced with java.nio.file.Files
invocations.

Modification:

Reduce dependency on external library guava by utilizing
java.nio.file.Files' methods instead of the ones provided by
com.google.common.io.Files (where applicable).

Result:

Keeping behaviour the same while having reduced dependency on guava.

Target: master
Signed-off-by: Jonas Grabber <[email protected]>
@jobegrabber jobegrabber mentioned this issue Feb 16, 2019
Merged
@LukasMansour LukasMansour linked a pull request Aug 3, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
easypick education
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove all remaining references of Guava's Files class. LukasMansour/dcache
2 participants
@kofemann @jobegrabber