Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No documentation and protection on 'Vec2i' initialisation #4

Closed
leguims opened this issue Jun 24, 2018 · 1 comment · May be fixed by #5
Closed

No documentation and protection on 'Vec2i' initialisation #4

leguims opened this issue Jun 24, 2018 · 1 comment · May be fixed by #5

Comments

@leguims
Copy link

leguims commented Jun 24, 2018

Hi,

Your repo is really useful, and a use it to do a Quoridor board game. When I try to use a-star, I find no documentation to know the relative limits to setWorldSize() method.

Now, I know, but it could be usefull to add this information in 'ReadMe.md' or in 'AStar.hpp'. Best fix is to add exception if 'Vec2i' when coordinates is out of range (std::out_of_range for example).

World = [ 0 ; WorldSize - 1 ]
All 'Vec2i.x' and 'Vec2i.y' have to be in [0 ; WorldSize - 1].

@leguims
Copy link
Author

leguims commented Jun 25, 2018

I pull a request to add exception and documentation in "Readme.md".

@daancode daancode closed this as completed Jul 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants