If "amount" is already converted to GBP why to we need to bother with the currency conversion/exchange rate work?

[daaronr]

fundraising_data_pull/R/process_data/combine_available_data.R

Line 48 in ab7dd48

#### Trying to fix exchange rates (see analysis_report) ####

If "amount" is already converted to GBP why to we need to bother with the currency conversion/exchange rate work?

@oskasf

[daaronr]

fundraisers_all <- fundraisers_all %>%
  mutate(
    total_raised = if_else(
      is.na(exchange_rate),
      grand_total_raised_excluding_gift_aid,
      grand_total_raised_excluding_gift_aid / exchange_rate),
      total_raised = replace(total_raised, total_raised == -Inf, 0))

Is this bit just relevant for non-UK-based fundraisers? (Which we decided to drop anyways)

[oskasf]

This is just relevant for non-UK based fundraisers, can go if we're dropping these anyway

[daaronr]

@oskasf Can you help me clean this up? It doesn't seem entirely separated from operations that need to be done on all pages including UK ones.

Can you

• separate this part out (just the stuff that is relevant for non-UK fundraisers) and put it in a separate .R file
• put that file in 'archive' or somewhere
• mention it in this file, in case we need to use it again?

Note that I also do not want this to interfere with your 'post-covid pages analysis'. If we are using the same construction files for several things we need to be careful.